Apply final to public API classes where possible - jmx-scraper, jmx-metrics

Author: trask

jmx-metrics/src/main/groovy/io/opentelemetry/contrib/jmxmetrics/ClientCallbackHandler.java

@@ -13,7 +13,7 @@
 import javax.security.auth.callback.UnsupportedCallbackException;
 import javax.security.sasl.RealmCallback;
 
-public class ClientCallbackHandler implements CallbackHandler {
+public final class ClientCallbackHandler implements CallbackHandler {
   private final String username;
   @Nullable private final char[] password;
   private final String realm;

jmx-metrics/src/main/groovy/io/opentelemetry/contrib/jmxmetrics/ConfigurationException.java

@@ -5,7 +5,7 @@
 
 package io.opentelemetry.contrib.jmxmetrics;
 
-public class ConfigurationException extends RuntimeException {
+public final class ConfigurationException extends RuntimeException {
   private static final long serialVersionUID = 0L;
 
   public ConfigurationException(final String message, final Throwable cause) {

jmx-metrics/src/main/groovy/io/opentelemetry/contrib/jmxmetrics/GroovyMetricEnvironment.java

@@ -37,7 +37,7 @@
 import java.util.stream.Collectors;
 import javax.annotation.Nullable;
 
-public class GroovyMetricEnvironment {
+public final class GroovyMetricEnvironment {
   private final SdkMeterProvider meterProvider;
   private final Meter meter;
 

jmx-metrics/src/main/groovy/io/opentelemetry/contrib/jmxmetrics/GroovyRunner.java

@@ -29,7 +29,7 @@
 import java.util.logging.Logger;
 import org.codehaus.groovy.control.CompilationFailedException;
 
-public class GroovyRunner {
+public final class GroovyRunner {
   private static final Logger logger = Logger.getLogger(GroovyRunner.class.getName());
 
   private final List<Script> scripts;

jmx-metrics/src/main/groovy/io/opentelemetry/contrib/jmxmetrics/JmxClient.java

@@ -22,7 +22,7 @@
 import javax.management.remote.JMXConnector;
 import javax.management.remote.JMXServiceURL;
 
-public class JmxClient {
+public final class JmxClient {
   private static final Logger logger = Logger.getLogger(JmxClient.class.getName());
 
   private final JMXServiceURL url;

jmx-metrics/src/main/groovy/io/opentelemetry/contrib/jmxmetrics/JmxConnectorHelper.java

@@ -20,7 +20,7 @@
 import javax.management.remote.rmi.RMIServer;
 import javax.rmi.ssl.SslRMIClientSocketFactory;
 
-public class JmxConnectorHelper {
+public final class JmxConnectorHelper {
 
   private static final Logger logger = Logger.getLogger(JmxConnectorHelper.class.getName());
 

jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/InvalidArgumentException.java

@@ -9,7 +9,7 @@
  * Exception indicating something is wrong with the provided arguments or reading the configuration
  * from them
  */
-public class InvalidArgumentException extends Exception {
+public final class InvalidArgumentException extends Exception {
 
   private static final long serialVersionUID = 0L;
 

jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/JmxConnectorBuilder.java

@@ -34,7 +34,7 @@
 import javax.security.auth.callback.UnsupportedCallbackException;
 import javax.security.sasl.RealmCallback;
 
-public class JmxConnectorBuilder {
+public final class JmxConnectorBuilder {
 
   private static final Logger logger = Logger.getLogger(JmxConnectorBuilder.class.getName());
 

jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/JmxScraper.java

@@ -35,7 +35,7 @@
 import javax.management.MBeanServerConnection;
 import javax.management.remote.JMXConnector;
 
-public class JmxScraper {
+public final class JmxScraper {
   private static final Logger logger = Logger.getLogger(JmxScraper.class.getName());
   private static final String CONFIG_ARG = "-config";
   private static final String TEST_ARG = "-test";

jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/config/JmxScraperConfig.java

@@ -23,7 +23,7 @@
 import javax.annotation.Nullable;
 
 /** This class keeps application settings */
-public class JmxScraperConfig {
+public final class JmxScraperConfig {
 
   private static final Logger logger = Logger.getLogger(JmxScraperConfig.class.getName());