wip, failing are commented

Author: SylvainJuge

jmx-scraper/src/integrationTest/java/io/opentelemetry/contrib/jmxscraper/target_systems/JettyIntegrationTest.java

@@ -6,7 +6,6 @@
 package io.opentelemetry.contrib.jmxscraper.target_systems;
 
 import static io.opentelemetry.contrib.jmxscraper.target_systems.MetricAssertions.assertGaugeWithAttributes;
-import static io.opentelemetry.contrib.jmxscraper.target_systems.MetricAssertions.assertSum;
 import static io.opentelemetry.contrib.jmxscraper.target_systems.MetricAssertions.assertSumWithAttributes;
 
 import io.opentelemetry.contrib.jmxscraper.JmxScraperContainer;
@@ -73,15 +72,28 @@ protected void verifyMetrics() {
                 "The maximum amount of time a session has been active.",
                 "s",
                 attrs -> attrs.containsKey("resource")),
-        metric ->
-            assertSum(metric, "jetty.select.count", "The number of select calls.", "{operations}"),
+//        metric ->
+//            assertSumWithAttributes(metric,
+//                "jetty.select.count",
+//                "The number of select calls.",
+//                "{operations}",
+//                // minor divergence from jetty.groovy with extra metrics attributes
+//                attrs -> attrs.containsKey("context"),
+//                attrs -> attrs.containsKey("id")
+//            ),
         metric ->
             assertGaugeWithAttributes(
                 metric,
                 "jetty.thread.count",
                 "The current number of threads.",
                 "{threads}",
                 attrs -> attrs.containsEntry("state", "busy"),
-                attrs -> attrs.containsEntry("state", "idle")));
+                attrs -> attrs.containsEntry("state", "idle"))/*,
+        metric ->
+            assertGauge(
+                metric,
+                "jetty.thread.queue.count",
+                "The current number of threads in the queue.",
+                "{threads}")*/);
   }
 }

jmx-scraper/src/main/resources/jetty.yaml

@@ -2,13 +2,20 @@
 
 rules:
 
-  - bean: org.eclipse.jetty.io:context=*,type=managedselector,id=*
-    mapping:
-      selectCount:
-        metric: jetty.select.count
-        type: counter
-        unit: "{operations}"
-        desc: The number of select calls.
+#  - bean: org.eclipse.jetty.io:context=*,type=managedselector,id=*
+#    mapping:
+#      selectCount:
+#        metric: jetty.select.count
+#        type: counter
+#        unit: "{operations}"
+#        desc: The number of select calls.
+#        metricAttribute:
+#          # minor divergence from jetty.groovy allowing to avoid warnings
+#          # 'id' is a numerical value in [0,9] by default
+#          # 'context' is a high cardinality value like 'HTTP_1_1@7674f035' but likely stable for the
+#          # duration of the jetty process lifecycle
+#          context: param(context)
+#          id: param(id)
 
   - bean: org.eclipse.jetty.server.session:context=*,type=sessionhandler,id=*
     prefix: jetty.session.
@@ -27,8 +34,7 @@ rules:
         desc: The total time sessions have been active.
       sessionTimeMax:
         metric: time.max
-        # here a 'counter' metric type would suit better, but gauge reflects
-        # how it's currently implemented in jetty.groovy
+        # here a 'counter' seems more appropriate but gauge reflects jetty.groovy impl.
         type: gauge
         unit: s
         desc: The maximum amount of time a session has been active.
@@ -39,11 +45,19 @@ rules:
     mapping:
       busyThreads:
         metric: count
+        # here an 'updowncounter' seems more appropriate but gauge reflects jetty.groovy impl.
+        type: gauge
         desc: The current number of threads.
         metricAttribute:
           state: const(busy)
       idleThreads:
         metric: count
+        # here an 'updowncounter' seems more appropriate but gauge reflects jetty.groovy impl.
+        type: gauge
         desc: The current number of threads.
         metricAttribute:
           state: const(idle)
+#      queueSize:
+#        metric: queue.count
+#        # here an 'updowncounter' seems more appropriate but gauge reflects jetty.groovy impl.
+#        type: gauge