Skip to content

Commit 0bb9585

Browse files
authored
Apply final to public API classes where possible - jmx-scraper, jmx-metrics (#2215)
1 parent 7d64775 commit 0bb9585

File tree

6 files changed

+6
-6
lines changed

6 files changed

+6
-6
lines changed

jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/InvalidArgumentException.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
* Exception indicating something is wrong with the provided arguments or reading the configuration
1010
* from them
1111
*/
12-
public class InvalidArgumentException extends Exception {
12+
public final class InvalidArgumentException extends Exception {
1313

1414
private static final long serialVersionUID = 0L;
1515

jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/JmxConnectorBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
import javax.security.auth.callback.UnsupportedCallbackException;
3535
import javax.security.sasl.RealmCallback;
3636

37-
public class JmxConnectorBuilder {
37+
public final class JmxConnectorBuilder {
3838

3939
private static final Logger logger = Logger.getLogger(JmxConnectorBuilder.class.getName());
4040

jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/JmxScraper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
import javax.management.MBeanServerConnection;
3636
import javax.management.remote.JMXConnector;
3737

38-
public class JmxScraper {
38+
public final class JmxScraper {
3939
private static final Logger logger = Logger.getLogger(JmxScraper.class.getName());
4040
private static final String CONFIG_ARG = "-config";
4141
private static final String TEST_ARG = "-test";

jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/config/JmxScraperConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
import javax.annotation.Nullable;
2424

2525
/** This class keeps application settings */
26-
public class JmxScraperConfig {
26+
public final class JmxScraperConfig {
2727

2828
private static final Logger logger = Logger.getLogger(JmxScraperConfig.class.getName());
2929

jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/config/PropertiesCustomizer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
import javax.annotation.Nullable;
1717

1818
/** Customizer of default SDK configuration and provider of effective scraper config */
19-
public class PropertiesCustomizer implements Function<ConfigProperties, Map<String, String>> {
19+
public final class PropertiesCustomizer implements Function<ConfigProperties, Map<String, String>> {
2020

2121
private static final Logger logger = Logger.getLogger(PropertiesCustomizer.class.getName());
2222

jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/config/PropertiesSupplier.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
import java.util.function.Supplier;
1212

1313
/** Configuration supplier for java properties */
14-
public class PropertiesSupplier implements Supplier<Map<String, String>> {
14+
public final class PropertiesSupplier implements Supplier<Map<String, String>> {
1515

1616
private final Properties properties;
1717

0 commit comments

Comments
 (0)