Skip to content

Commit 0eccc4e

Browse files
committed
fix version resolution for semconv
1 parent 11fbc11 commit 0eccc4e

File tree

1 file changed

+10
-36
lines changed

1 file changed

+10
-36
lines changed

buildSrc/src/main/kotlin/otel.java-conventions.gradle.kts

Lines changed: 10 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,7 @@ val DEFAULT_JAVA_VERSION = JavaVersion.VERSION_17
2323
java {
2424
toolchain {
2525
languageVersion.set(
26-
otelJava.minJavaVersionSupported.map {
27-
JavaLanguageVersion.of(
28-
Math.max(
29-
it.majorVersion.toInt(),
30-
DEFAULT_JAVA_VERSION.majorVersion.toInt()
31-
)
32-
)
33-
}
26+
otelJava.minJavaVersionSupported.map { JavaLanguageVersion.of(Math.max(it.majorVersion.toInt(), DEFAULT_JAVA_VERSION.majorVersion.toInt())) }
3427
)
3528
}
3629

@@ -43,7 +36,7 @@ tasks {
4336
with(options) {
4437
release.set(otelJava.minJavaVersionSupported.map { it.majorVersion.toInt() })
4538

46-
if (name != "jmhCompileGeneratedClasses") {
39+
if (name!="jmhCompileGeneratedClasses") {
4740
compilerArgs.addAll(
4841
listOf(
4942
"-Xlint:all",
@@ -113,36 +106,21 @@ plugins.withId("otel.publish-conventions") {
113106
tasks {
114107
register("generateVersionResource") {
115108
val moduleName = otelJava.moduleName
116-
val propertiesDir = moduleName.map {
117-
layout.buildDirectory.file(
118-
"generated/properties/${
119-
it.replace(
120-
'.',
121-
'/'
122-
)
123-
}"
124-
)
125-
}
109+
val propertiesDir = moduleName.map { layout.buildDirectory.file("generated/properties/${it.replace('.', '/')}") }
126110
val projectVersion = project.version.toString()
127111

128112
inputs.property("project.version", projectVersion)
129113
outputs.dir(propertiesDir)
130114

131115
doLast {
132-
File(
133-
propertiesDir.get().get().asFile,
134-
"version.properties"
135-
).writeText("contrib.version=${projectVersion}")
116+
File(propertiesDir.get().get().asFile, "version.properties").writeText("contrib.version=${projectVersion}")
136117
}
137118
}
138119
}
139120

140121
sourceSets {
141122
main {
142-
output.dir(
143-
layout.buildDirectory.dir("generated/properties"),
144-
"builtBy" to "generateVersionResource"
145-
)
123+
output.dir(layout.buildDirectory.dir("generated/properties"), "builtBy" to "generateVersionResource")
146124
}
147125
}
148126
}
@@ -199,21 +177,18 @@ fun isJavaVersionAllowed(version: JavaVersion): Boolean {
199177
if (otelJava.minJavaVersionSupported.get() > version) {
200178
return false
201179
}
202-
if (otelJava.maxJavaVersionForTests.isPresent && otelJava.maxJavaVersionForTests.get()
203-
.compareTo(version) < 0
204-
) {
180+
if (otelJava.maxJavaVersionForTests.isPresent && otelJava.maxJavaVersionForTests.get().compareTo(version) < 0) {
205181
return false
206182
}
207183
return true
208184
}
209185

210186
afterEvaluate {
211-
val testJavaVersion =
212-
gradle.startParameter.projectProperties["testJavaVersion"]?.let(JavaVersion::toVersion)
213-
val useJ9 = gradle.startParameter.projectProperties["testJavaVM"]?.run { this == "openj9" }
187+
val testJavaVersion = gradle.startParameter.projectProperties["testJavaVersion"]?.let(JavaVersion::toVersion)
188+
val useJ9 = gradle.startParameter.projectProperties["testJavaVM"]?.run { this=="openj9" }
214189
?: false
215190
tasks.withType<Test>().configureEach {
216-
if (testJavaVersion != null) {
191+
if (testJavaVersion!=null) {
217192
javaLauncher.set(
218193
javaToolchains.launcherFor {
219194
languageVersion.set(JavaLanguageVersion.of(testJavaVersion.majorVersion))
@@ -241,6 +216,5 @@ dependencyCheck {
241216
suppressionFile = "buildscripts/dependency-check-suppressions.xml"
242217
failBuildOnCVSS = 7.0f // fail on high or critical CVE
243218
nvd.apiKey = System.getenv("NVD_API_KEY")
244-
nvd.delay =
245-
3500 // until next dependency check release (https://github.com/jeremylong/DependencyCheck/pull/6333)
219+
nvd.delay = 3500 // until next dependency check release (https://github.com/jeremylong/DependencyCheck/pull/6333)
246220
}

0 commit comments

Comments
 (0)