Update errorprone (#412)

* Update errorprone

* Sync

* Spotless

* More

Author: trask

aws-xray/src/main/java/io/opentelemetry/contrib/awsxray/AwsXrayRemoteSampler.java

@@ -205,6 +205,7 @@ private void fetchTargets() {
   }
 
   @Override
+  @SuppressWarnings("Interruption")
   public void close() {
     ScheduledFuture<?> pollFuture = this.pollFuture;
     if (pollFuture != null) {

buildSrc/src/main/kotlin/otel.errorprone-conventions.gradle.kts

@@ -7,13 +7,13 @@ plugins {
   id("net.ltgt.nullaway")
 }
 
-val disableErrorProne = properties["disableErrorProne"]?.toString()?.toBoolean() ?: false
-
 dependencies {
   errorprone("com.google.errorprone:error_prone_core")
   errorprone("com.uber.nullaway:nullaway")
 }
 
+val disableErrorProne = properties["disableErrorProne"]?.toString()?.toBoolean() ?: false
+
 tasks {
   withType<JavaCompile>().configureEach {
     with(options) {
@@ -26,6 +26,9 @@ tasks {
         disableWarningsInGeneratedCode.set(true)
         allDisabledChecksAsWarnings.set(true)
 
+        // Ignore warnings for generated classes
+        excludedPaths.set(".*/build/generated/.*")
+
         // Still Java 8 mostly
         disable("Varifier")
 
@@ -45,23 +48,14 @@ tasks {
         // deprecation warning.
         disable("UnnecessarilyFullyQualified")
 
-        // Ignore warnings for protobuf and jmh generated files.
-        excludedPaths.set(".*generated.*|.*internal.shaded.*")
-
+        // TODO (trask) use animal sniffer
         disable("Java7ApiChecker")
         disable("Java8ApiChecker")
         disable("AndroidJdkLibsChecker")
 
         // apparently disabling android doesn't disable this
         disable("StaticOrDefaultInterfaceMethod")
 
-        // Prevents defensive null checks and we have nullaway
-        disable("ParameterMissingNullable")
-
-        // until we have everything converted, we need these
-        disable("JdkObsolete")
-        disable("UnnecessaryAnonymousClass")
-
         // We don't depend on Guava so use normal splitting
         disable("StringSplitter")
 
@@ -72,6 +66,12 @@ tasks {
         // We don't get much benefit from it anyways.
         disable("InlineMeSuggester")
 
+        // We have nullaway so don't need errorprone nullable checks which have more false positives.
+        disable("FieldMissingNullable")
+        disable("ParameterMissingNullable")
+        disable("ReturnMissingNullable")
+        disable("VoidMissingNullable")
+
         // allow UPPERCASE type parameter names
         disable("TypeParameterNaming")
 

dependencyManagement/build.gradle.kts

@@ -41,7 +41,7 @@ val DEPENDENCY_SETS = listOf(
     ),
     DependencySet(
         "com.google.errorprone",
-        "2.12.1",
+        "2.14.0",
         listOf("error_prone_annotations", "error_prone_core")
     ),
     DependencySet(