refactor to use logger for text output

Author: SylvainJuge

jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/JmxScraper.java

@@ -26,6 +26,7 @@
 import java.util.Optional;
 import java.util.Properties;
 import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.logging.Level;
 import java.util.logging.Logger;
 import javax.management.MBeanServerConnection;
 import javax.management.remote.JMXConnector;
@@ -45,11 +46,11 @@ public class JmxScraper {
    *
    * @param args - must be of the form "-config {jmx_config_path,'-'}"
    */
-  @SuppressWarnings({"SystemOut", "SystemExitOutsideMain"})
+  @SuppressWarnings("SystemExitOutsideMain")
   public static void main(String[] args) {
 
     // set log format
-    System.setProperty("java.util.logging.SimpleFormatter.format", "%1$tFT%1$tT.%1$tL%1$tz | %4$s: %5$s%n");
+    System.setProperty("java.util.logging.SimpleFormatter.format", "%1$tF %1$tT %4$s %5$s%n");
 
     try {
       Properties argsConfig = parseArgs(Arrays.asList(args));
@@ -77,18 +78,19 @@ public static void main(String[] args) {
       JmxScraper jmxScraper = new JmxScraper(connectorBuilder, service, scraperConfig);
       jmxScraper.start();
     } catch (ConfigurationException e) {
-      System.err.println("ERROR: invalid configuration " + e.getMessage());
+      logger.log(Level.SEVERE, "ERROR: invalid configuration ", e);
       System.exit(1);
     } catch (ArgumentsParsingException e) {
-      System.err.println(
+      logger.log(Level.SEVERE, "ERROR: invalid configuration provided through arguments", e);
+      logger.info(
           "Usage: java -jar <path_to_jmxscraper.jar> "
               + "-config <path_to_config.properties or - for stdin>");
       System.exit(1);
     } catch (IOException e) {
-      System.err.println("Unable to connect " + e.getMessage());
+      logger.log(Level.SEVERE, "Unable to connect ", e);
       System.exit(2);
     } catch (RuntimeException e) {
-      e.printStackTrace(System.err);
+      logger.log(Level.SEVERE, e.getMessage(), e);
       System.exit(3);
     }
   }

jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/config/JmxScraperConfig.java

@@ -137,13 +137,13 @@ public static JmxScraperConfig fromConfig(ConfigProperties config) {
     String customConfig = config.getString(JMX_CUSTOM_CONFIG);
     List<String> targetSystem = config.getList(JMX_TARGET_SYSTEM);
     if (targetSystem.isEmpty() && customConfig == null) {
-      throw new ConfigurationException("at least one of '" + JMX_TARGET_SYSTEM + "' or '" + JMX_CUSTOM_CONFIG + "' must be set");
+      throw new ConfigurationException(
+          "at least one of '" + JMX_TARGET_SYSTEM + "' or '" + JMX_CUSTOM_CONFIG + "' must be set");
     }
     targetSystem.forEach(
         s -> {
           if (!AVAILABLE_TARGET_SYSTEMS.contains(s)) {
-            throw new ConfigurationException(
-                "unsupported target system: '" + s + "'");
+            throw new ConfigurationException("unsupported target system: '" + s + "'");
           }
         });
     scraperConfig.customJmxScrapingConfigPath = customConfig;
@@ -157,5 +157,4 @@ public static JmxScraperConfig fromConfig(ConfigProperties config) {
 
     return scraperConfig;
   }
-
 }

jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/config/PropertiesCustomizer.java

@@ -37,8 +37,11 @@ public Map<String, String> apply(ConfigProperties config) {
     // providing compatibility with the existing 'otel.jmx.interval.milliseconds' config option
     long intervalLegacy = config.getLong(JMX_INTERVAL_LEGACY, -1);
     if (config.getDuration(METRIC_EXPORT_INTERVAL) == null && intervalLegacy > 0) {
-      logger.warning(METRIC_EXPORT_INTERVAL + " deprecated option is used, replacing with '"
-          + METRIC_EXPORT_INTERVAL + "' metric sdk configuration is recommended");
+      logger.warning(
+          METRIC_EXPORT_INTERVAL
+              + " deprecated option is used, replacing with '"
+              + METRIC_EXPORT_INTERVAL
+              + "' metric sdk configuration is recommended");
       result.put(METRIC_EXPORT_INTERVAL, intervalLegacy + "ms");
     }
 

jmx-scraper/src/test/java/io/opentelemetry/contrib/jmxscraper/config/JmxScraperConfigTest.java

@@ -63,8 +63,7 @@ void shouldPassValidation() {
   void shouldCreateMinimalValidConfiguration() {
     // Given
     Properties properties = new Properties();
-    properties.setProperty(
-        JMX_SERVICE_URL, "jservice:jmx:rmi:///jndi/rmi://localhost:9010/jmxrmi");
+    properties.setProperty(JMX_SERVICE_URL, "jservice:jmx:rmi:///jndi/rmi://localhost:9010/jmxrmi");
     properties.setProperty(JMX_CUSTOM_CONFIG, "/file.properties");
 
     // When

jmx-scraper/src/test/java/io/opentelemetry/contrib/jmxscraper/config/PropertiesCustomizerTest.java

@@ -98,6 +98,5 @@ void sdkMetricExportIntervalPriority() {
     assertThat(customizer.getScraperConfig().getSamplingInterval())
         .describedAs("jmx export interval must be ignored")
         .isEqualTo(Duration.ofSeconds(15));
-
   }
 }