pr review

Author: zeitlinger

gcp-auth-extension/src/main/java/io/opentelemetry/contrib/gcp/auth/ConfigurableOption.java

@@ -92,8 +92,7 @@ String getUserReadableName() {
   }
 
   /**
-   * Retrieves the configured value for this option. This method checks the environment variable
-   * first and then the system property.
+   * Retrieves the configured value for this option.
    *
    * @return The configured value as a string, or throws an exception if not configured.
    * @throws ConfigurationException if neither the environment variable nor the system property is
@@ -113,10 +112,9 @@ <T> T getRequiredConfiguredValue(
   }
 
   /**
-   * Retrieves the configured value for this option. This method checks the environment variable
-   * first and then the system property.
+   * Retrieves the configured value for this option.
    *
-   * @return The configured value as a string, or throws an exception if not configured.
+   * @return The configured value as a string, or {@code null} if not configured.
    */
   @Nullable
   <T> T getConfiguredValue(

gcp-auth-extension/src/main/java/io/opentelemetry/contrib/gcp/auth/GcpAuthCustomizerProvider.java renamed to gcp-auth-extension/src/main/java/io/opentelemetry/contrib/gcp/auth/GcpAuthDeclarativeConfigurationCustomizerProvider.java

@@ -11,6 +11,7 @@
 
 import com.google.auth.oauth2.GoogleCredentials;
 import com.google.auto.service.AutoService;
+import com.google.common.annotations.VisibleForTesting;
 import io.opentelemetry.contrib.sdk.autoconfigure.ConfigPropertiesUtil;
 import io.opentelemetry.contrib.sdk.autoconfigure.DeclarativeConfigPropertiesBridgeBuilder;
 import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
@@ -37,7 +38,7 @@
 import javax.annotation.Nullable;
 
 @AutoService(DeclarativeConfigurationCustomizerProvider.class)
-public class GcpAuthCustomizerProvider implements DeclarativeConfigurationCustomizerProvider {
+public class GcpAuthDeclarativeConfigurationCustomizerProvider implements DeclarativeConfigurationCustomizerProvider {
 
   static final String SIGNAL_TARGET_WARNING_YAML_FIX_SUGGESTION =
       String.format(

gcp-auth-extension/src/test/java/io/opentelemetry/contrib/gcp/auth/GcpAuthCustomizerProviderTest.java renamed to gcp-auth-extension/src/test/java/io/opentelemetry/contrib/gcp/auth/GcpAuthDeclarativeConfigurationCustomizerProviderTest.java

@@ -5,7 +5,7 @@
 
 package io.opentelemetry.contrib.gcp.auth;
 
-import static io.opentelemetry.contrib.gcp.auth.GcpAuthCustomizerProvider.SIGNAL_TARGET_WARNING_YAML_FIX_SUGGESTION;
+import static io.opentelemetry.contrib.gcp.auth.GcpAuthDeclarativeConfigurationCustomizerProvider.SIGNAL_TARGET_WARNING_YAML_FIX_SUGGESTION;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
@@ -20,7 +20,7 @@
 import java.util.Collections;
 import org.junit.jupiter.api.Test;
 
-class GcpAuthCustomizerProviderTest {
+class GcpAuthDeclarativeConfigurationCustomizerProviderTest {
 
   @Test
   void declarativeConfig() throws IOException {
@@ -51,7 +51,7 @@ void declarativeConfig() throws IOException {
     OpenTelemetryConfigurationModel model =
         DeclarativeConfiguration.parse(
             new ByteArrayInputStream(yaml.getBytes(StandardCharsets.UTF_8)));
-    ConfigProperties properties = GcpAuthCustomizerProvider.getConfigProperties(model);
+    ConfigProperties properties = GcpAuthDeclarativeConfigurationCustomizerProvider.getConfigProperties(model);
 
     assertThat(GcpAuthAutoConfigurationCustomizerProvider.targetSignals(properties))
         .containsExactly("metrics", "traces");
@@ -64,7 +64,7 @@ void declarativeConfig() throws IOException {
         .thenReturn(
             Collections.singletonMap("x-goog-user-project", Collections.singletonList("qp")));
 
-    GcpAuthCustomizerProvider.customize(model, credentials, properties);
+    GcpAuthDeclarativeConfigurationCustomizerProvider.customize(model, credentials, properties);
 
     String header =
         "headers=\\[io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.NameStringValuePairModel@.*\\[name=x-goog-user-project,value=qp]";