Skip to content

Commit 1d7f482

Browse files
robsundayrobsunday
authored
JMX Scraper - YAML config and integration test for HBase (#1538)
1 parent 436b166 commit 1d7f482

File tree

5 files changed

+839
-39
lines changed

5 files changed

+839
-39
lines changed

‎jmx-metrics/src/integrationTest/java/io/opentelemetry/contrib/jmxmetrics/target_systems/HbaseIntegrationTest.java‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -43,22 +43,22 @@ void endToEnd() {
4343
metric,
4444
"hbase.master.region_server.count",
4545
"The number of region servers.",
46-
"{servers}",
46+
"{server}",
4747
attrs -> attrs.contains(entry("state", "dead")),
4848
attrs -> attrs.contains(entry("state", "live"))),
4949
metric ->
5050
assertSum(
5151
metric,
5252
"hbase.master.regions_in_transition.count",
5353
"The number of regions that are in transition.",
54-
"{regions}",
54+
"{region}",
5555
/* isMonotonic= */ false),
5656
metric ->
5757
assertSum(
5858
metric,
5959
"hbase.master.regions_in_transition.over_threshold",
6060
"The number of regions that have been in transition longer than a threshold time.",
61-
"{regions}",
61+
"{region}",
6262
/* isMonotonic= */ false),
6363
metric ->
6464
assertGauge(
@@ -71,14 +71,14 @@ void endToEnd() {
7171
metric,
7272
"hbase.region_server.region.count",
7373
"The number of regions hosted by the region server.",
74-
"{regions}",
74+
"{region}",
7575
attrs -> attrs.containsKey("region_server")),
7676
metric ->
7777
assertSumWithAttributes(
7878
metric,
7979
"hbase.region_server.disk.store_file.count",
8080
"The number of store files on disk currently managed by the region server.",
81-
"{files}",
81+
"{file}",
8282
attrs -> attrs.containsKey("region_server")),
8383
metric ->
8484
assertSumWithAttributes(
@@ -92,22 +92,22 @@ void endToEnd() {
9292
metric,
9393
"hbase.region_server.write_ahead_log.count",
9494
"The number of write ahead logs not yet archived.",
95-
"{logs}",
95+
"{log}",
9696
attrs -> attrs.containsKey("region_server")),
9797
metric ->
9898
assertSumWithAttributes(
9999
metric,
100100
"hbase.region_server.request.count",
101101
"The number of requests received.",
102-
"{requests}",
102+
"{request}",
103103
attrs -> attrs.contains(entry("state", "write")),
104104
attrs -> attrs.contains(entry("state", "read"))),
105105
metric ->
106106
assertSumWithAttributes(
107107
metric,
108108
"hbase.region_server.queue.length",
109109
"The number of RPC handlers actively servicing requests.",
110-
"{handlers}",
110+
"{handler}",
111111
attrs -> attrs.contains(entry("state", "flush")),
112112
attrs -> attrs.contains(entry("state", "compaction"))),
113113
metric ->
@@ -122,7 +122,7 @@ void endToEnd() {
122122
metric,
123123
"hbase.region_server.request.count",
124124
"The number of requests received.",
125-
"{requests}",
125+
"{request}",
126126
attrs -> attrs.contains(entry("state", "write")),
127127
attrs -> attrs.contains(entry("state", "read"))),
128128
metric ->
@@ -347,7 +347,7 @@ void endToEnd() {
347347
metric,
348348
"hbase.region_server.operations.slow",
349349
"Number of operations that took over 1000ms to complete.",
350-
"{operations}",
350+
"{operation}",
351351
attrs -> attrs.contains(entry("operation", "delete")),
352352
attrs -> attrs.contains(entry("operation", "append")),
353353
attrs -> attrs.contains(entry("operation", "get")),
@@ -358,21 +358,21 @@ void endToEnd() {
358358
metric,
359359
"hbase.region_server.open_connection.count",
360360
"The number of open connections at the RPC layer.",
361-
"{connections}",
361+
"{connection}",
362362
attrs -> attrs.containsKey("region_server")),
363363
metric ->
364364
assertSumWithAttributes(
365365
metric,
366366
"hbase.region_server.active_handler.count",
367367
"The number of RPC handlers actively servicing requests.",
368-
"{handlers}",
368+
"{handler}",
369369
attrs -> attrs.containsKey("region_server")),
370370
metric ->
371371
assertSumWithAttributes(
372372
metric,
373373
"hbase.region_server.queue.request.count",
374374
"The number of currently enqueued requests.",
375-
"{requests}",
375+
"{request}",
376376
attrs -> attrs.contains(entry("state", "replication")),
377377
attrs -> attrs.contains(entry("state", "user")),
378378
attrs -> attrs.contains(entry("state", "priority"))),
@@ -381,7 +381,7 @@ void endToEnd() {
381381
metric,
382382
"hbase.region_server.authentication.count",
383383
"Number of client connection authentication failures/successes.",
384-
"{authentication requests}",
384+
"{authentication request}",
385385
attrs -> attrs.contains(entry("state", "successes")),
386386
attrs -> attrs.contains(entry("state", "failures"))),
387387
metric ->

‎jmx-metrics/src/main/resources/target-systems/hbase.groovy‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -16,45 +16,45 @@
1616

1717
def beanMasterServer = otel.mbeans("Hadoop:service=HBase,name=Master,sub=Server")
1818
otel.instrument(beanMasterServer, "hbase.master.region_server.count",
19-
"The number of region servers.", "{servers}",
19+
"The number of region servers.", "{server}",
2020
["numDeadRegionServers":["state" : {"dead"}], "numRegionServers": ["state" : {"live"}]],
2121
otel.&longUpDownCounterCallback)
2222

2323
def beanMasterAssignmentManager = otel.mbean("Hadoop:service=HBase,name=Master,sub=AssignmentManager")
2424
otel.instrument(beanMasterAssignmentManager, "hbase.master.regions_in_transition.count",
25-
"The number of regions that are in transition.", "{regions}",
25+
"The number of regions that are in transition.", "{region}",
2626
"ritCount", otel.&longUpDownCounterCallback)
2727
otel.instrument(beanMasterAssignmentManager, "hbase.master.regions_in_transition.over_threshold",
28-
"The number of regions that have been in transition longer than a threshold time.", "{regions}",
28+
"The number of regions that have been in transition longer than a threshold time.", "{region}",
2929
"ritCountOverThreshold", otel.&longUpDownCounterCallback)
3030
otel.instrument(beanMasterAssignmentManager, "hbase.master.regions_in_transition.oldest_age",
3131
"The age of the longest region in transition.", "ms",
3232
"ritOldestAge", otel.&longValueCallback)
3333

3434
def beanRegionServerServer = otel.mbean("Hadoop:service=HBase,name=RegionServer,sub=Server")
3535
otel.instrument(beanRegionServerServer, "hbase.region_server.region.count",
36-
"The number of regions hosted by the region server.", "{regions}",
36+
"The number of regions hosted by the region server.", "{region}",
3737
["region_server" : { mbean -> mbean.getProperty("tag.Hostname") }],
3838
"regionCount", otel.&longUpDownCounterCallback)
3939
otel.instrument(beanRegionServerServer, "hbase.region_server.disk.store_file.count",
40-
"The number of store files on disk currently managed by the region server.", "{files}",
40+
"The number of store files on disk currently managed by the region server.", "{file}",
4141
["region_server" : { mbean -> mbean.getProperty("tag.Hostname") }],
4242
"storeFileCount", otel.&longUpDownCounterCallback)
4343
otel.instrument(beanRegionServerServer, "hbase.region_server.disk.store_file.size",
4444
"Aggregate size of the store files on disk.", "By",
4545
["region_server" : { mbean -> mbean.getProperty("tag.Hostname") }],
4646
"storeFileSize", otel.&longUpDownCounterCallback)
4747
otel.instrument(beanRegionServerServer, "hbase.region_server.write_ahead_log.count",
48-
"The number of write ahead logs not yet archived.", "{logs}",
48+
"The number of write ahead logs not yet archived.", "{log}",
4949
["region_server" : { mbean -> mbean.getProperty("tag.Hostname") }],
5050
"hlogFileCount", otel.&longUpDownCounterCallback)
5151
otel.instrument(beanRegionServerServer, "hbase.region_server.request.count",
52-
"The number of requests received.", "{requests}",
52+
"The number of requests received.", "{request}",
5353
["region_server" : { mbean -> mbean.getProperty("tag.Hostname") }],
5454
["writeRequestCount":["state" : {"write"}], "readRequestCount": ["state" : {"read"}]],
5555
otel.&longUpDownCounterCallback)
5656
otel.instrument(beanRegionServerServer, "hbase.region_server.queue.length",
57-
"The number of RPC handlers actively servicing requests.", "{handlers}",
57+
"The number of RPC handlers actively servicing requests.", "{handler}",
5858
["region_server" : { mbean -> mbean.getProperty("tag.Hostname") }],
5959
["flushQueueLength":["state" : {"flush"}], "compactionQueueLength": ["state" : {"compaction"}]],
6060
otel.&longUpDownCounterCallback)
@@ -63,7 +63,7 @@ otel.instrument(beanRegionServerServer, "hbase.region_server.blocked_update.time
6363
["region_server" : { mbean -> mbean.getProperty("tag.Hostname") }],
6464
"updatesBlockedTime", otel.&longValueCallback)
6565
otel.instrument(beanRegionServerServer, "hbase.region_server.block_cache.operation.count",
66-
"Number of block cache hits/misses.", "{operations}",
66+
"Number of block cache hits/misses.", "{operation}",
6767
["region_server" : { mbean -> mbean.getProperty("tag.Hostname") }],
6868
["blockCacheMissCount":["state" : {"miss"}], "blockCacheHitCount": ["state" : {"hit"}]],
6969
otel.&longValueCallback)
@@ -199,7 +199,7 @@ otel.instrument(beanRegionServerServer, "hbase.region_server.operation.increment
199199
"Increment_median", otel.&longValueCallback)
200200

201201
otel.instrument(beanRegionServerServer, "hbase.region_server.operations.slow",
202-
"Number of operations that took over 1000ms to complete.", "{operations}",
202+
"Number of operations that took over 1000ms to complete.", "{operation}",
203203
["region_server" : { mbean -> mbean.getProperty("tag.Hostname") }],
204204
[
205205
"slowDeleteCount":["operation" : {"delete"}],
@@ -212,15 +212,15 @@ otel.instrument(beanRegionServerServer, "hbase.region_server.operations.slow",
212212

213213
def beanRegionServerIPC = otel.mbean("Hadoop:service=HBase,name=RegionServer,sub=IPC")
214214
otel.instrument(beanRegionServerIPC, "hbase.region_server.open_connection.count",
215-
"The number of open connections at the RPC layer.", "{connections}",
215+
"The number of open connections at the RPC layer.", "{connection}",
216216
["region_server" : { mbean -> mbean.getProperty("tag.Hostname") }],
217217
"numOpenConnections", otel.&longUpDownCounterCallback)
218218
otel.instrument(beanRegionServerIPC, "hbase.region_server.active_handler.count",
219-
"The number of RPC handlers actively servicing requests.", "{handlers}",
219+
"The number of RPC handlers actively servicing requests.", "{handler}",
220220
["region_server" : { mbean -> mbean.getProperty("tag.Hostname") }],
221221
"numActiveHandler", otel.&longUpDownCounterCallback)
222222
otel.instrument(beanRegionServerIPC, "hbase.region_server.queue.request.count",
223-
"The number of currently enqueued requests.", "{requests}",
223+
"The number of currently enqueued requests.", "{request}",
224224
["region_server" : { mbean -> mbean.getProperty("tag.Hostname") }],
225225
[
226226
"numCallsInReplicationQueue":["state" : {"replication"}],
@@ -229,7 +229,7 @@ otel.instrument(beanRegionServerIPC, "hbase.region_server.queue.request.count",
229229
],
230230
otel.&longUpDownCounterCallback)
231231
otel.instrument(beanRegionServerIPC, "hbase.region_server.authentication.count",
232-
"Number of client connection authentication failures/successes.", "{authentication requests}",
232+
"Number of client connection authentication failures/successes.", "{authentication request}",
233233
["region_server" : { mbean -> mbean.getProperty("tag.Hostname") }],
234234
["authenticationSuccesses":["state" : {"successes"}], "authenticationFailures": ["state" : {"failures"}]],
235235
otel.&longUpDownCounterCallback)
@@ -246,4 +246,4 @@ otel.instrument(beanJVMMetrics, "hbase.region_server.gc.young_gen.time",
246246
otel.instrument(beanJVMMetrics, "hbase.region_server.gc.old_gen.time",
247247
"Time spent in garbage collection of the old generation.", "ms",
248248
["region_server" : { mbean -> mbean.getProperty("tag.Hostname") }],
249-
"GcTimeMillisConcurrentMarkSweep", otel.&longCounterCallback)
249+
"GcTimeMillisConcurrentMarkSweep", otel.&longCounterCallback)

0 commit comments

Comments
 (0)