Skip to content

Commit 2084d65

Browse files
committed
use component loader
1 parent cfa2f54 commit 2084d65

File tree

6 files changed

+18
-24
lines changed

6 files changed

+18
-24
lines changed

aws-resources/src/test/java/io/opentelemetry/contrib/aws/resource/ResourceComponentProviderTest.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,17 @@
77

88
import static org.assertj.core.api.Assertions.assertThat;
99

10-
import io.opentelemetry.sdk.autoconfigure.internal.SpiHelper;
10+
import io.opentelemetry.common.ComponentLoader;
1111
import io.opentelemetry.sdk.autoconfigure.spi.internal.ComponentProvider;
12-
import java.util.List;
1312
import org.junit.jupiter.api.Test;
1413

1514
public class ResourceComponentProviderTest {
1615

1716
@Test
1817
@SuppressWarnings("rawtypes")
1918
void providerIsLoaded() {
20-
List<ComponentProvider> providers =
21-
SpiHelper.create(ResourceComponentProviderTest.class.getClassLoader())
19+
Iterable<ComponentProvider> providers =
20+
ComponentLoader.forClassLoader(ResourceComponentProviderTest.class.getClassLoader())
2221
.load(ComponentProvider.class);
2322
assertThat(providers).extracting(ComponentProvider::getName).containsExactly("aws");
2423
}

azure-resources/src/test/java/io/opentelemetry/contrib/azure/resource/ResourceComponentProviderTest.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,17 @@
77

88
import static org.assertj.core.api.Assertions.assertThat;
99

10-
import io.opentelemetry.sdk.autoconfigure.internal.SpiHelper;
10+
import io.opentelemetry.common.ComponentLoader;
1111
import io.opentelemetry.sdk.autoconfigure.spi.internal.ComponentProvider;
12-
import java.util.List;
1312
import org.junit.jupiter.api.Test;
1413

1514
public class ResourceComponentProviderTest {
1615

1716
@Test
1817
@SuppressWarnings("rawtypes")
1918
void providerIsLoaded() {
20-
List<ComponentProvider> providers =
21-
SpiHelper.create(ResourceComponentProviderTest.class.getClassLoader())
19+
Iterable<ComponentProvider> providers =
20+
ComponentLoader.forClassLoader(ResourceComponentProviderTest.class.getClassLoader())
2221
.load(ComponentProvider.class);
2322
assertThat(providers).extracting(ComponentProvider::getName).containsExactly("azure");
2423
}

cloudfoundry-resources/src/test/java/io/opentelemetry/contrib/cloudfoundry/resources/ResourceComponentProviderTest.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,17 @@
77

88
import static org.assertj.core.api.Assertions.assertThat;
99

10-
import io.opentelemetry.sdk.autoconfigure.internal.SpiHelper;
10+
import io.opentelemetry.common.ComponentLoader;
1111
import io.opentelemetry.sdk.autoconfigure.spi.internal.ComponentProvider;
12-
import java.util.List;
1312
import org.junit.jupiter.api.Test;
1413

1514
public class ResourceComponentProviderTest {
1615

1716
@Test
1817
@SuppressWarnings("rawtypes")
1918
void providerIsLoaded() {
20-
List<ComponentProvider> providers =
21-
SpiHelper.create(ResourceComponentProviderTest.class.getClassLoader())
19+
Iterable<ComponentProvider> providers =
20+
ComponentLoader.forClassLoader(ResourceComponentProviderTest.class.getClassLoader())
2221
.load(ComponentProvider.class);
2322
assertThat(providers).extracting(ComponentProvider::getName).containsExactly("cloud_foundry");
2423
}

gcp-resources/src/test/java/io/opentelemetry/contrib/gcp/resource/ResourceComponentProviderTest.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,17 @@
77

88
import static org.assertj.core.api.Assertions.assertThat;
99

10-
import io.opentelemetry.sdk.autoconfigure.internal.SpiHelper;
10+
import io.opentelemetry.common.ComponentLoader;
1111
import io.opentelemetry.sdk.autoconfigure.spi.internal.ComponentProvider;
12-
import java.util.List;
1312
import org.junit.jupiter.api.Test;
1413

1514
public class ResourceComponentProviderTest {
1615

1716
@Test
1817
@SuppressWarnings("rawtypes")
1918
void providerIsLoaded() {
20-
List<ComponentProvider> providers =
21-
SpiHelper.create(ResourceComponentProviderTest.class.getClassLoader())
19+
Iterable<ComponentProvider> providers =
20+
ComponentLoader.forClassLoader(ResourceComponentProviderTest.class.getClassLoader())
2221
.load(ComponentProvider.class);
2322
assertThat(providers).extracting(ComponentProvider::getName).containsExactly("gcp");
2423
}

maven-extension/src/test/java/io/opentelemetry/maven/resources/ResourceComponentProviderTest.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,17 @@
77

88
import static org.assertj.core.api.Assertions.assertThat;
99

10-
import io.opentelemetry.sdk.autoconfigure.internal.SpiHelper;
10+
import io.opentelemetry.common.ComponentLoader;
1111
import io.opentelemetry.sdk.autoconfigure.spi.internal.ComponentProvider;
12-
import java.util.List;
1312
import org.junit.jupiter.api.Test;
1413

1514
public class ResourceComponentProviderTest {
1615

1716
@Test
1817
@SuppressWarnings("rawtypes")
1918
void providerIsLoaded() {
20-
List<ComponentProvider> providers =
21-
SpiHelper.create(ResourceComponentProviderTest.class.getClassLoader())
19+
Iterable<ComponentProvider> providers =
20+
ComponentLoader.forClassLoader(ResourceComponentProviderTest.class.getClassLoader())
2221
.load(ComponentProvider.class);
2322
assertThat(providers).extracting(ComponentProvider::getName).contains("maven");
2423
}

resource-providers/src/test/java/io/opentelemetry/contrib/resourceproviders/ResourceComponentProviderTest.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,17 @@
77

88
import static org.assertj.core.api.Assertions.assertThat;
99

10-
import io.opentelemetry.sdk.autoconfigure.internal.SpiHelper;
10+
import io.opentelemetry.common.ComponentLoader;
1111
import io.opentelemetry.sdk.autoconfigure.spi.internal.ComponentProvider;
12-
import java.util.List;
1312
import org.junit.jupiter.api.Test;
1413

1514
public class ResourceComponentProviderTest {
1615

1716
@Test
1817
@SuppressWarnings("rawtypes")
1918
void providerIsLoaded() {
20-
List<ComponentProvider> providers =
21-
SpiHelper.create(ResourceComponentProviderTest.class.getClassLoader())
19+
Iterable<ComponentProvider> providers =
20+
ComponentLoader.forClassLoader(ResourceComponentProviderTest.class.getClassLoader())
2221
.load(ComponentProvider.class);
2322
assertThat(providers).extracting(ComponentProvider::getName).contains("app_server");
2423
}

0 commit comments

Comments
 (0)