refactor to use ExtendedSpanProcessor.onEnding

Author: SylvainJuge

span-stacktrace/src/main/java/io/opentelemetry/contrib/stacktrace/StackTraceSpanProcessor.java

@@ -6,19 +6,19 @@
 package io.opentelemetry.contrib.stacktrace;
 
 import io.opentelemetry.api.common.AttributeKey;
-import io.opentelemetry.contrib.stacktrace.internal.AbstractSimpleChainingSpanProcessor;
-import io.opentelemetry.contrib.stacktrace.internal.MutableSpan;
+import io.opentelemetry.context.Context;
 import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
+import io.opentelemetry.sdk.trace.ReadWriteSpan;
 import io.opentelemetry.sdk.trace.ReadableSpan;
-import io.opentelemetry.sdk.trace.SpanProcessor;
+import io.opentelemetry.sdk.trace.internal.ExtendedSpanProcessor;
 import java.io.PrintWriter;
 import java.io.StringWriter;
 import java.time.Duration;
 import java.util.function.Predicate;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 
-public class StackTraceSpanProcessor extends AbstractSimpleChainingSpanProcessor {
+public class StackTraceSpanProcessor implements ExtendedSpanProcessor {
 
   private static final String CONFIG_MIN_DURATION =
       "otel.java.experimental.span-stacktrace.min.duration";
@@ -35,13 +35,11 @@ public class StackTraceSpanProcessor extends AbstractSimpleChainingSpanProcessor
   private final Predicate<ReadableSpan> filterPredicate;
 
   /**
-   * @param next next span processor to invoke
    * @param minSpanDurationNanos minimum span duration in ns for stacktrace capture
    * @param filterPredicate extra filter function to exclude spans if needed
    */
   public StackTraceSpanProcessor(
-      SpanProcessor next, long minSpanDurationNanos, Predicate<ReadableSpan> filterPredicate) {
-    super(next);
+      long minSpanDurationNanos, Predicate<ReadableSpan> filterPredicate) {
     this.minSpanDurationNanos = minSpanDurationNanos;
     this.filterPredicate = filterPredicate;
     if (minSpanDurationNanos < 0) {
@@ -55,47 +53,51 @@ public StackTraceSpanProcessor(
   }
 
   /**
-   * @param next next span processor to invoke
    * @param config configuration
    * @param filterPredicate extra filter function to exclude spans if needed
    */
-  public StackTraceSpanProcessor(
-      SpanProcessor next, ConfigProperties config, Predicate<ReadableSpan> filterPredicate) {
+  public StackTraceSpanProcessor(ConfigProperties config, Predicate<ReadableSpan> filterPredicate) {
     this(
-        next,
         config.getDuration(CONFIG_MIN_DURATION, CONFIG_MIN_DURATION_DEFAULT).toNanos(),
         filterPredicate);
   }
 
   @Override
-  protected boolean requiresStart() {
+  public boolean isStartRequired() {
     return false;
   }
 
   @Override
-  protected boolean requiresEnd() {
+  public void onStart(Context context, ReadWriteSpan readWriteSpan) {}
+
+  @Override
+  public boolean isOnEndingRequired() {
     return true;
   }
 
   @Override
-  protected ReadableSpan doOnEnd(ReadableSpan span) {
+  public void onEnding(ReadWriteSpan span) {
     if (minSpanDurationNanos < 0 || span.getLatencyNanos() < minSpanDurationNanos) {
-      return span;
+      return;
     }
     if (span.getAttribute(SPAN_STACKTRACE) != null) {
       // Span already has a stacktrace, do not override
-      return span;
+      return;
     }
     if (!filterPredicate.test(span)) {
-      return span;
+      return;
     }
-    MutableSpan mutableSpan = MutableSpan.makeMutable(span);
+    span.setAttribute(SPAN_STACKTRACE, generateSpanEndStacktrace());
+  }
 
-    String stacktrace = generateSpanEndStacktrace();
-    mutableSpan.setAttribute(SPAN_STACKTRACE, stacktrace);
-    return mutableSpan;
+  @Override
+  public boolean isEndRequired() {
+    return false;
   }
 
+  @Override
+  public void onEnd(ReadableSpan readableSpan) {}
+
   private static String generateSpanEndStacktrace() {
     Throwable exception = new Throwable();
     StringWriter stringWriter = new StringWriter();