Skip to content

Commit 25c42bf

Browse files
committed
baggage is in a separate PR
1 parent d7d4915 commit 25c42bf

File tree

6 files changed

+15
-107
lines changed

6 files changed

+15
-107
lines changed

baggage-processor/build.gradle.kts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,19 +8,11 @@ description = "OpenTelemetry Baggage Span Processor"
88
otelJava.moduleName.set("io.opentelemetry.contrib.baggage.processor")
99

1010
dependencies {
11-
implementation(project(":declarative-config-bridge"))
12-
13-
annotationProcessor("com.google.auto.service:auto-service")
14-
compileOnly("com.google.auto.service:auto-service-annotations")
1511
api("io.opentelemetry:opentelemetry-api")
1612
api("io.opentelemetry:opentelemetry-sdk")
1713
implementation("io.opentelemetry:opentelemetry-sdk-extension-autoconfigure-spi")
18-
compileOnly("io.opentelemetry:opentelemetry-sdk-extension-incubator")
1914

20-
testAnnotationProcessor("com.google.auto.service:auto-service")
21-
testCompileOnly("com.google.auto.service:auto-service-annotations")
2215
testImplementation("io.opentelemetry:opentelemetry-sdk-extension-autoconfigure")
23-
testImplementation("io.opentelemetry:opentelemetry-sdk-extension-incubator")
2416
testImplementation("io.opentelemetry:opentelemetry-sdk-testing")
2517
testImplementation("org.mockito:mockito-inline")
2618
testImplementation("com.google.guava:guava")

baggage-processor/src/main/java/io/opentelemetry/contrib/baggage/processor/BaggageLogRecordComponentProvider.java

Lines changed: 0 additions & 34 deletions
This file was deleted.

baggage-processor/src/main/java/io/opentelemetry/contrib/baggage/processor/BaggageProcessorCustomizer.java

Lines changed: 12 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,14 @@
55

66
package io.opentelemetry.contrib.baggage.processor;
77

8-
import com.google.auto.service.AutoService;
98
import io.opentelemetry.sdk.autoconfigure.spi.AutoConfigurationCustomizer;
109
import io.opentelemetry.sdk.autoconfigure.spi.AutoConfigurationCustomizerProvider;
1110
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
1211
import io.opentelemetry.sdk.logs.SdkLoggerProviderBuilder;
1312
import io.opentelemetry.sdk.trace.SdkTracerProviderBuilder;
1413
import java.util.List;
1514

16-
@AutoService(AutoConfigurationCustomizerProvider.class)
1715
public class BaggageProcessorCustomizer implements AutoConfigurationCustomizerProvider {
18-
1916
@Override
2017
public void customize(AutoConfigurationCustomizer autoConfigurationCustomizer) {
2118
autoConfigurationCustomizer
@@ -33,53 +30,39 @@ public void customize(AutoConfigurationCustomizer autoConfigurationCustomizer) {
3330

3431
private static void addSpanProcessor(
3532
SdkTracerProviderBuilder sdkTracerProviderBuilder, ConfigProperties config) {
36-
if (spanKeys(config).isEmpty()) {
33+
List<String> keys =
34+
config.getList("otel.java.experimental.span-attributes.copy-from-baggage.include");
35+
36+
if (keys.isEmpty()) {
3737
return;
3838
}
3939

40-
sdkTracerProviderBuilder.addSpanProcessor(createBaggageSpanProcessor(config));
41-
}
42-
43-
static BaggageSpanProcessor createBaggageSpanProcessor(ConfigProperties config) {
44-
return createBaggageSpanProcessor(spanKeys(config));
40+
sdkTracerProviderBuilder.addSpanProcessor(createBaggageSpanProcessor(keys));
4541
}
4642

4743
static BaggageSpanProcessor createBaggageSpanProcessor(List<String> keys) {
48-
if (matchAll(keys)) {
44+
if (keys.size() == 1 && keys.get(0).equals("*")) {
4945
return BaggageSpanProcessor.allowAllBaggageKeys();
5046
}
5147
return new BaggageSpanProcessor(keys::contains);
5248
}
5349

54-
static List<String> spanKeys(ConfigProperties config) {
55-
return config.getList("otel.java.experimental.span-attributes.copy-from-baggage.include");
56-
}
57-
5850
private static void addLogRecordProcessor(
5951
SdkLoggerProviderBuilder sdkLoggerProviderBuilder, ConfigProperties config) {
60-
if (logKeys(config).isEmpty()) {
52+
List<String> keys =
53+
config.getList("otel.java.experimental.log-attributes.copy-from-baggage.include");
54+
55+
if (keys.isEmpty()) {
6156
return;
6257
}
6358

64-
sdkLoggerProviderBuilder.addLogRecordProcessor(createBaggageLogRecordProcessor(config));
65-
}
66-
67-
static BaggageLogRecordProcessor createBaggageLogRecordProcessor(ConfigProperties config) {
68-
return createBaggageLogRecordProcessor(logKeys(config));
59+
sdkLoggerProviderBuilder.addLogRecordProcessor(createBaggageLogRecordProcessor(keys));
6960
}
7061

7162
static BaggageLogRecordProcessor createBaggageLogRecordProcessor(List<String> keys) {
72-
if (matchAll(keys)) {
63+
if (keys.size() == 1 && keys.get(0).equals("*")) {
7364
return BaggageLogRecordProcessor.allowAllBaggageKeys();
7465
}
7566
return new BaggageLogRecordProcessor(keys::contains);
7667
}
77-
78-
static List<String> logKeys(ConfigProperties config) {
79-
return config.getList("otel.java.experimental.log-attributes.copy-from-baggage.include");
80-
}
81-
82-
private static boolean matchAll(List<String> keys) {
83-
return keys.size() == 1 && keys.get(0).equals("*");
84-
}
8568
}

baggage-processor/src/main/java/io/opentelemetry/contrib/baggage/processor/BaggageSpanComponentProvider.java

Lines changed: 0 additions & 34 deletions
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
io.opentelemetry.contrib.baggage.processor.BaggageProcessorCustomizer

baggage-processor/src/test/java/io/opentelemetry/contrib/baggage/processor/BaggageProcessorCustomizerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,9 @@ private static OpenTelemetrySdk getOpenTelemetrySdk(
103103
// We set the export interval of the spans to 10 ms. The default value is 5
104104
// seconds.
105105
"otel.bsp.schedule.delay", // span exporter
106-
"100",
106+
"10",
107107
"otel.blrp.schedule.delay", // log exporter
108-
"100",
108+
"10",
109109
"otel.traces.exporter",
110110
MEMORY_EXPORTER,
111111
"otel.metrics.exporter",

0 commit comments

Comments
 (0)