Skip to content

Commit 260cbc4

Browse files
committed
Removing nested try with resources as suggested in PR reviews
1 parent 3c3830b commit 260cbc4

File tree

1 file changed

+11
-17
lines changed

1 file changed

+11
-17
lines changed

opamp-client/src/main/java/io/opentelemetry/opamp/client/internal/request/service/HttpRequestService.java

Lines changed: 11 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -128,24 +128,18 @@ public void run() {
128128
}
129129

130130
private void doSendRequest() {
131-
try {
132-
AgentToServer agentToServer =
133-
Objects.requireNonNull(requestSupplier).get().getAgentToServer();
134-
135-
byte[] data = agentToServer.encodeByteString().toByteArray();
136-
try (HttpSender.Response response =
137-
requestSender.send(new ByteArrayWriter(data), data.length).get()) {
138-
if (isSuccessful(response)) {
139-
handleSuccessResponse(
140-
Response.create(ServerToAgent.ADAPTER.decode(response.bodyInputStream())));
141-
} else {
142-
handleHttpError(response);
143-
}
144-
} catch (IOException e) {
145-
getCallback().onRequestFailed(e);
131+
AgentToServer agentToServer = Objects.requireNonNull(requestSupplier).get().getAgentToServer();
132+
133+
byte[] data = agentToServer.encodeByteString().toByteArray();
134+
try (HttpSender.Response response =
135+
requestSender.send(new ByteArrayWriter(data), data.length).get()) {
136+
if (isSuccessful(response)) {
137+
handleSuccessResponse(
138+
Response.create(ServerToAgent.ADAPTER.decode(response.bodyInputStream())));
139+
} else {
140+
handleHttpError(response);
146141
}
147-
148-
} catch (InterruptedException e) {
142+
} catch (IOException | InterruptedException e) {
149143
getCallback().onRequestFailed(e);
150144
} catch (ExecutionException e) {
151145
if (e.getCause() != null) {

0 commit comments

Comments
 (0)