remove duplicated code

Author: SylvainJuge

span-stacktrace/src/main/java/io/opentelemetry/contrib/stacktrace/StackTraceSpanProcessor.java

@@ -7,21 +7,15 @@
 
 import io.opentelemetry.api.common.AttributeKey;
 import io.opentelemetry.context.Context;
-import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
 import io.opentelemetry.sdk.trace.ReadWriteSpan;
 import io.opentelemetry.sdk.trace.ReadableSpan;
 import io.opentelemetry.sdk.trace.internal.ExtendedSpanProcessor;
 import java.io.PrintWriter;
 import java.io.StringWriter;
-import java.time.Duration;
 import java.util.function.Predicate;
 
 public class StackTraceSpanProcessor implements ExtendedSpanProcessor {
 
-  private static final String CONFIG_MIN_DURATION =
-      "otel.java.experimental.span-stacktrace.min.duration";
-  private static final Duration CONFIG_MIN_DURATION_DEFAULT = Duration.ofMillis(5);
-
   // inlined incubating attribute to prevent direct dependency on incubating semconv
   private static final AttributeKey<String> SPAN_STACKTRACE =
       AttributeKey.stringKey("code.stacktrace");
@@ -40,16 +34,6 @@ public StackTraceSpanProcessor(
     this.filterPredicate = filterPredicate;
   }
 
-  /**
-   * @param config configuration
-   * @param filterPredicate extra filter function to exclude spans if needed
-   */
-  public StackTraceSpanProcessor(ConfigProperties config, Predicate<ReadableSpan> filterPredicate) {
-    this(
-        config.getDuration(CONFIG_MIN_DURATION, CONFIG_MIN_DURATION_DEFAULT).toNanos(),
-        filterPredicate);
-  }
-
   @Override
   public boolean isStartRequired() {
     return false;

span-stacktrace/src/test/java/io/opentelemetry/contrib/stacktrace/StackTraceSpanProcessorTest.java

@@ -73,10 +73,10 @@ void spanWithExistingStackTrace() {
   }
 
   private static void checkSpanWithStackTrace(
-      Predicate<ReadableSpan> filterPredicate, String configString, long spanDurationNanos) {
+      Predicate<ReadableSpan> filterPredicate, String minDurationString, long spanDurationNanos) {
     checkSpan(
         filterPredicate,
-        configString,
+        minDurationString,
         spanDurationNanos,
         Function.identity(),
         (stackTrace) ->
@@ -86,18 +86,18 @@ private static void checkSpanWithStackTrace(
   }
 
   private static void checkSpanWithoutStackTrace(
-      Predicate<ReadableSpan> filterPredicate, String configString, long spanDurationNanos) {
+      Predicate<ReadableSpan> filterPredicate, String minDurationString, long spanDurationNanos) {
     checkSpan(
         filterPredicate,
-        configString,
+        minDurationString,
         spanDurationNanos,
         Function.identity(),
         (stackTrace) -> assertThat(stackTrace).describedAs("no stack trace expected").isNull());
   }
 
   private static void checkSpan(
       Predicate<ReadableSpan> filterPredicate,
-      String configString,
+      String minDurationString,
       long spanDurationNanos,
       Function<SpanBuilder, SpanBuilder> customizeSpanBuilder,
       Consumer<String> stackTraceCheck) {
@@ -107,13 +107,14 @@ private static void checkSpan(
     SpanProcessor exportProcessor = SimpleSpanProcessor.create(spansExporter);
 
     Map<String, String> configMap = new HashMap<>();
-    if (configString != null) {
-      configMap.put("otel.java.experimental.span-stacktrace.min.duration", configString);
+    if (minDurationString != null) {
+      configMap.put("otel.java.experimental.span-stacktrace.min.duration", minDurationString);
     }
+    long minDuration = StackTraceAutoConfig.getMinDuration(
+        DefaultConfigProperties.createFromMap(configMap));
 
     StackTraceSpanProcessor processor =
-        new StackTraceSpanProcessor(
-            DefaultConfigProperties.createFromMap(configMap), filterPredicate);
+        new StackTraceSpanProcessor(minDuration, filterPredicate);
 
     try (OpenTelemetrySdk sdk =
         OpenTelemetrySdk.builder()