Skip to content

Commit 2bd86c0

Browse files
committed
Updating tests
1 parent 04488b1 commit 2bd86c0

File tree

2 files changed

+4
-13
lines changed

2 files changed

+4
-13
lines changed

disk-buffering/src/test/java/io/opentelemetry/contrib/disk/buffering/FromDiskExporterImplTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ void setUp() throws IOException {
5151
wrapped = mock();
5252
exporter =
5353
FromDiskExporterImpl.<SpanData>builder(
54-
TestData.getConfiguration(rootDir, SignalTypes.spans, clock))
54+
TestData.getStorage(rootDir, SignalTypes.spans, clock))
5555
.setDeserializer(deserializer)
5656
.setExportFunction(wrapped::export)
5757
.build();

disk-buffering/src/test/java/io/opentelemetry/contrib/disk/buffering/internal/storage/TestData.java

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66
package io.opentelemetry.contrib.disk.buffering.internal.storage;
77

88
import io.opentelemetry.contrib.disk.buffering.config.StorageConfiguration;
9-
import io.opentelemetry.contrib.disk.buffering.config.TemporaryFileProvider;
10-
import io.opentelemetry.contrib.disk.buffering.internal.files.DefaultTemporaryFileProvider;
119
import io.opentelemetry.contrib.disk.buffering.internal.utils.SignalTypes;
1210
import io.opentelemetry.sdk.common.Clock;
1311
import java.io.File;
@@ -21,22 +19,15 @@ public final class TestData {
2119
public static final int MAX_FILE_SIZE = 100;
2220
public static final int MAX_FOLDER_SIZE = 300;
2321

24-
public static StorageConfiguration getDefaultConfiguration(File rootDir) {
25-
TemporaryFileProvider fileProvider = DefaultTemporaryFileProvider.getInstance();
26-
return getConfiguration(fileProvider, rootDir);
27-
}
28-
29-
public static Storage getDefaultStorage(File rootDir, SignalTypes types, Clock clock)
22+
public static Storage getStorage(File rootDir, SignalTypes types, Clock clock)
3023
throws IOException {
31-
TemporaryFileProvider fileProvider = DefaultTemporaryFileProvider.getInstance();
3224
return Storage.builder(types)
33-
.setStorageConfiguration(getConfiguration(fileProvider, rootDir))
25+
.setStorageConfiguration(getConfiguration(rootDir))
3426
.setStorageClock(clock)
3527
.build();
3628
}
3729

38-
public static StorageConfiguration getConfiguration(
39-
TemporaryFileProvider fileProvider, File rootDir) {
30+
public static StorageConfiguration getConfiguration(File rootDir) {
4031
return StorageConfiguration.builder()
4132
.setRootDir(rootDir)
4233
.setMaxFileAgeForWriteMillis(MAX_FILE_AGE_FOR_WRITE_MILLIS)

0 commit comments

Comments
 (0)