Setting nonnull for all params by default

Author: LikeTheSalad

opamp-client/src/main/java/io/opentelemetry/opamp/client/internal/OpampClient.java

@@ -6,7 +6,7 @@
 package io.opentelemetry.opamp.client.internal;
 
 import io.opentelemetry.opamp.client.internal.response.MessageData;
-import javax.annotation.Nonnull;
+import javax.annotation.Nullable;
 import opamp.proto.AgentDescription;
 import opamp.proto.RemoteConfigStatus;
 import opamp.proto.ServerErrorResponse;
@@ -67,7 +67,7 @@ interface Callbacks {
      *
      * @param client The relevant {@link OpampClient} instance.
      */
-    void onConnect(@Nonnull OpampClient client);
+    void onConnect(OpampClient client);
 
     /**
      * Called when the connection to the Server cannot be established. May be called after {@link
@@ -77,7 +77,7 @@ interface Callbacks {
      * @param client The relevant {@link OpampClient} instance.
      * @param throwable The exception.
      */
-    void onConnectFailed(@Nonnull OpampClient client, Throwable throwable);
+    void onConnectFailed(OpampClient client, @Nullable Throwable throwable);
 
     /**
      * Called when the Server reports an error in response to some previously sent request. Useful
@@ -88,7 +88,7 @@ interface Callbacks {
      * @param client The relevant {@link OpampClient} instance.
      * @param errorResponse The error returned by the Server.
      */
-    void onErrorResponse(@Nonnull OpampClient client, @Nonnull ServerErrorResponse errorResponse);
+    void onErrorResponse(OpampClient client, ServerErrorResponse errorResponse);
 
     /**
      * Called when the Agent receives a message that needs processing. See {@link MessageData}
@@ -102,6 +102,6 @@ interface Callbacks {
      * @param client The relevant {@link OpampClient} instance.
      * @param messageData The server response data that needs processing.
      */
-    void onMessage(@Nonnull OpampClient client, @Nonnull MessageData messageData);
+    void onMessage(OpampClient client, MessageData messageData);
   }
 }

opamp-client/src/main/java/io/opentelemetry/opamp/client/internal/package-info.java

@@ -0,0 +1,9 @@
+/*
+ * Copyright The OpenTelemetry Authors
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+@ParametersAreNonnullByDefault
+package io.opentelemetry.opamp.client.internal;
+
+import javax.annotation.ParametersAreNonnullByDefault;

opamp-client/src/main/java/io/opentelemetry/opamp/client/internal/state/InMemoryState.java

@@ -16,11 +16,11 @@
 abstract class InMemoryState<T> implements State<T> {
   private final AtomicReference<T> state = new AtomicReference<>();
 
-  public InMemoryState(@Nonnull T initialValue) {
+  public InMemoryState(T initialValue) {
     state.set(initialValue);
   }
 
-  public void set(@Nonnull T value) {
+  public void set(T value) {
     state.set(value);
   }