Skip to content

Commit 34f0d20

Browse files
opentelemetrybotdependabot[bot]trask
authored
[release/v1.25.x] Bump io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha from 1.24.0-alpha to 1.25.0-alpha (#842)
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Trask Stalnaker <[email protected]>
1 parent 1c85239 commit 34f0d20

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed

aws-xray/src/main/java/io/opentelemetry/contrib/awsxray/SamplingRuleApplier.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -343,11 +343,11 @@ private static String getArn(Attributes attributes, Resource resource) {
343343

344344
@Nullable
345345
private static String getLambdaArn(Attributes attributes, Resource resource) {
346-
String arn = resource.getAttributes().get(ResourceAttributes.FAAS_ID);
346+
String arn = resource.getAttributes().get(ResourceAttributes.CLOUD_RESOURCE_ID);
347347
if (arn != null) {
348348
return arn;
349349
}
350-
return attributes.get(ResourceAttributes.FAAS_ID);
350+
return attributes.get(ResourceAttributes.CLOUD_RESOURCE_ID);
351351
}
352352

353353
@Nullable

aws-xray/src/test/java/io/opentelemetry/contrib/awsxray/SamplingRuleApplierTest.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -500,7 +500,9 @@ class AwsLambdaTest {
500500
.put(
501501
ResourceAttributes.CLOUD_PLATFORM,
502502
ResourceAttributes.CloudPlatformValues.AWS_LAMBDA)
503-
.put(ResourceAttributes.FAAS_ID, "arn:aws:xray:us-east-1:595986152929:my-service")
503+
.put(
504+
ResourceAttributes.CLOUD_RESOURCE_ID,
505+
"arn:aws:xray:us-east-1:595986152929:my-service")
504506
.build();
505507

506508
private final Attributes attributes =
@@ -521,10 +523,12 @@ void resourceFaasIdMatches() {
521523
void spanFaasIdMatches() {
522524
Resource resource =
523525
Resource.create(
524-
removeAttribute(this.resource.getAttributes(), ResourceAttributes.FAAS_ID));
526+
removeAttribute(this.resource.getAttributes(), ResourceAttributes.CLOUD_RESOURCE_ID));
525527
Attributes attributes =
526528
this.attributes.toBuilder()
527-
.put(ResourceAttributes.FAAS_ID, "arn:aws:xray:us-east-1:595986152929:my-service")
529+
.put(
530+
ResourceAttributes.CLOUD_RESOURCE_ID,
531+
"arn:aws:xray:us-east-1:595986152929:my-service")
528532
.build();
529533
assertThat(applier.matches(attributes, resource)).isTrue();
530534
}

dependencyManagement/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ val DEPENDENCY_BOMS = listOf(
1717
"com.linecorp.armeria:armeria-bom:1.23.1",
1818
"org.junit:junit-bom:5.9.2",
1919
"io.grpc:grpc-bom:1.54.1",
20-
"io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha:1.24.0-alpha",
20+
"io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha:1.25.0-alpha",
2121
"org.testcontainers:testcontainers-bom:1.18.0"
2222
)
2323

0 commit comments

Comments
 (0)