Skip to content

Commit 366b81a

Browse files
committed
add tests for custom yaml
1 parent 3a4e519 commit 366b81a

File tree

2 files changed

+25
-1
lines changed

2 files changed

+25
-1
lines changed

jmx-scraper/src/integrationTest/java/io/opentelemetry/contrib/jmxscraper/target_systems/JvmIntegrationTest.java

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,10 @@ protected GenericContainer<?> createTargetContainer(int jmxPort) {
3030
@Override
3131
protected JmxScraperContainer customizeScraperContainer(
3232
JmxScraperContainer scraper, GenericContainer<?> target, Path tempDir) {
33-
return scraper.withTargetSystem("jvm");
33+
return scraper
34+
.withTargetSystem("jvm")
35+
// also testing custom yaml
36+
.withCustomYaml("custom-metrics.yaml");
3437
}
3538

3639
@Override
@@ -48,6 +51,16 @@ protected MetricsVerifier createMetricsVerifier() {
4851
nameAttributeMatchers("PS MarkSweep", "PS Scavenge");
4952

5053
return MetricsVerifier.create()
54+
// custom metric in custom-metrics.yaml
55+
.add(
56+
"custom.jvm.uptime",
57+
metric ->
58+
metric
59+
.hasDescription("JVM uptime in milliseconds")
60+
.hasUnit("ms")
61+
.isCounter()
62+
.hasDataPointsWithoutAttributes())
63+
// metrics for 'jvm' target system
5164
.add(
5265
"jvm.classes.loaded",
5366
metric ->
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
---
2+
3+
rules:
4+
5+
- bean: java.lang:type=Runtime
6+
mapping:
7+
Uptime:
8+
metric: custom.jvm.uptime
9+
type: counter
10+
unit: ms
11+
desc: JVM uptime in milliseconds

0 commit comments

Comments
 (0)