use mise file tasks

zeitlinger · zeitlinger · commit 3ce4c4eecccf · 2025-09-30T15:02:44.000+02:00
diff --git a/.github/workflows/reusable-link-check.yml b/.github/workflows/reusable-link-check.yml
@@ -24,11 +24,15 @@ jobs:
 
       - name: Link check (modified files only)
         if: github.event_name == 'pull_request'
+        # todo only if config did not change
         env:
           GITHUB_TOKEN: ${{ github.token }}
         run: mise run lint:links-in-modified-file --base origin/${{ github.base_ref }} --head ${{ github.event.pull_request.head.sha }}
 
+# todo one stop commend for linting that also works locally: lint:modified-links
+
       - name: Link check (all files)
+        # todo also if not PR but config changed
         if: github.event_name != 'pull_request'
         env:
           GITHUB_TOKEN: ${{ github.token }}
diff --git a/.mise/tasks/lint/links-if-config-changed b/.mise/tasks/lint/links-if-config-changed
@@ -4,12 +4,16 @@
 set -e
 
 #USAGE flag "--base <base>" help="base branch to compare against" default="origin/main"
-#USAGE flag "--head <head>" help="head branch to compare against" default="HEAD"
+#USAGE flag "--head <head>" help="head branch to compare against" default=""
 
-merge_base=$(git merge-base "$usage_base" HEAD)
+if [ "$usage_head" == "''" ]; then
+  usage_head=""
+fi
+
+# todo use .mise/tasks/lint/* for config change detection
 
 # Check if lychee config was modified
-config_modified=$(git diff --name-only "$merge_base"..."$usage_head" \
+config_modified=$(git diff --name-only --merge_base "$usage_base" $usage_head \
                   | grep -E '^(\.github/config/lychee\.toml|mise\.toml)$' || true)
 
 if [ -z "$config_modified" ] ; then
diff --git a/.mise/tasks/lint/links-in-modified-files b/.mise/tasks/lint/links-in-modified-files
@@ -1,25 +1,28 @@
 #!/usr/bin/env bash
 #MISE description="Lint links in modified files"
 
-set -e
+set -ex
 
 #USAGE flag "--base <base>" help="base branch to compare against" default="origin/main"
-#USAGE flag "--head <head>" help="head branch to compare against" default="HEAD"
+#USAGE flag "--head <head>" help="head branch to compare against" default=""
+
+if [ "$usage_head" == "''" ]; then
+  usage_head=""
+fi
 
-merge_base=$(git merge-base "$usage_base" HEAD)
 # Using lychee's default extension filter here to match when it runs against all files
 # Note: --diff-filter=d filters out deleted files
-modified_files=$(git diff --name-only --diff-filter=d "$merge_base"..."$usage_head" \
+modified_files=$(git diff --name-only --diff-filter=d "$usage_base" $usage_head \
                   | grep -E '\.(md|mkd|mdx|mdown|mdwn|mkdn|mkdown|markdown|html|htm|txt)$' \
                   | tr '\n' ' ' || true)
 
 # Check if lychee config was modified
-config_modified=$(git diff --name-only "$merge_base"..."$usage_head" \
+config_modified=$(git diff --name-only --merge-base "$usage_base" $usage_head \
                   | grep -E '^(\.github/config/lychee\.toml|mise\.toml)$' || true)
 
 if [ -z "$modified_files" ] && [ -z "$config_modified" ] ; then
   echo "No modified files and no config changes, skipping link linting."
   exit 0
 fi
 
-mise run lint-links "$modified_files"
+mise run lint:links $modified_files
