simplify matchesValue

SylvainJuge · SylvainJuge · commit 45ba126f3c2c · 2024-12-06T15:54:45.000+01:00
diff --git a/jmx-scraper/src/integrationTest/java/io/opentelemetry/contrib/jmxscraper/assertions/AttributeMatcher.java b/jmx-scraper/src/integrationTest/java/io/opentelemetry/contrib/jmxscraper/assertions/AttributeMatcher.java
@@ -57,9 +57,6 @@ public String toString() {
    * @return true if this matcher is matching provided value, false otherwise.
    */
   boolean matchesValue(String value) {
-    if (attributeValue == null) {
-      return true;
-    }
-    return Objects.equals(attributeValue, value);
+    return attributeValue == null || attributeValue.equals(value);
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -57,9 +57,6 @@ public String toString() {`
`57`	`57`	`* @return true if this matcher is matching provided value, false otherwise.`
`58`	`58`	`*/`
`59`	`59`	`boolean matchesValue(String value) {`
`60`		`- if (attributeValue == null) {`
`61`		`- return true;`
`62`		`- }`
`63`		`- return Objects.equals(attributeValue, value);`
	`60`	`+ return attributeValue == null \|\| attributeValue.equals(value);`
`64`	`61`	`}`
`65`	`62`	`}`