Skip to content

Commit 466b28d

Browse files
committed
align link checking with changes in instrumentation repo
1 parent 6a92818 commit 466b28d

File tree

6 files changed

+65
-27
lines changed

6 files changed

+65
-27
lines changed
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# this file exists so that Renovate can auto-update docker image versions that are then used elsewhere
2+
3+
FROM lycheeverse/lychee:sha-2aa22f8@sha256:2e3786630482c41f9f2dd081e06d7da1c36d66996e8cf6573409b8bc418d48c4 AS lychee

.github/scripts/link-check.sh

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
#!/bin/bash
2+
3+
set -e
4+
5+
export MSYS_NO_PATHCONV=1 # for Git Bash on Windows
6+
7+
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
8+
LYCHEE_CONFIG="$SCRIPT_DIR/../../.lychee.toml"
9+
DEPENDENCIES_DOCKERFILE="$SCRIPT_DIR/dependencies.dockerfile"
10+
11+
# Extract lychee version from dependencies.dockerfile
12+
LYCHEE_VERSION=$(grep "FROM lycheeverse/lychee:" "$DEPENDENCIES_DOCKERFILE" | sed 's/.*FROM lycheeverse\/lychee:\([^ ]*\).*/\1/')
13+
14+
# Build the lychee command with optional GitHub token
15+
CMD="lycheeverse/lychee:$LYCHEE_VERSION --verbose --config $(basename "$LYCHEE_CONFIG")"
16+
17+
# Add GitHub token if available
18+
if [[ -n "$GITHUB_TOKEN" ]]; then
19+
CMD="$CMD --github-token $GITHUB_TOKEN"
20+
fi
21+
22+
# Add the target directory
23+
CMD="$CMD ."
24+
25+
# Determine if we should allocate a TTY
26+
DOCKER_FLAGS="--rm --init"
27+
if [[ -t 0 ]]; then
28+
DOCKER_FLAGS="$DOCKER_FLAGS -it"
29+
else
30+
DOCKER_FLAGS="$DOCKER_FLAGS -i"
31+
fi
32+
33+
# Run lychee with proper signal handling
34+
# shellcheck disable=SC2086
35+
exec docker run $DOCKER_FLAGS -v "$(dirname "$LYCHEE_CONFIG")":/data -w /data $CMD

.github/workflows/build.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,12 @@ jobs:
118118
name: integration-test-results
119119
path: jmx-metrics/build/reports/tests/integrationTest
120120

121-
markdown-link-check:
122-
uses: ./.github/workflows/reusable-markdown-link-check.yml
121+
link-check:
122+
# release branches are excluded to avoid unnecessary maintenance if external links break
123+
# (and also because the README.md might need update on release branches before the release
124+
# download has been published)
125+
if: "!startsWith(github.ref_name, 'release/')"
126+
uses: ./.github/workflows/reusable-link-check.yml
123127

124128
markdown-lint-check:
125129
uses: ./.github/workflows/reusable-markdown-lint.yml
@@ -142,7 +146,7 @@ jobs:
142146
# and so would not short-circuit if used in the second-last position
143147
name: publish-snapshots${{ (github.ref_name != 'main' || github.repository != 'open-telemetry/opentelemetry-java-contrib') && ' (skipped)' || '' }}
144148
needs:
145-
# intentionally not blocking snapshot publishing on markdown-link-check or misspell-check
149+
# intentionally not blocking snapshot publishing on link-check or misspell-check
146150
- build
147151
- integration-test
148152
runs-on: ubuntu-latest
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
name: Reusable - Link check
2+
3+
on:
4+
workflow_call:
5+
6+
permissions:
7+
contents: read
8+
9+
jobs:
10+
link-check:
11+
runs-on: ubuntu-latest
12+
steps:
13+
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
14+
15+
- name: Link check
16+
env:
17+
GITHUB_TOKEN: ${{ github.token }}
18+
run: ./.github/scripts/link-check.sh

.github/workflows/reusable-markdown-link-check.yml

Lines changed: 0 additions & 19 deletions
This file was deleted.

lychee.toml renamed to .lychee.toml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,9 @@
11
timeout = 30
22
retry_wait_time = 5
33
max_retries = 6
4-
max_concurrency = 1
4+
max_concurrency = 4
55

6-
# Stealth
7-
user_agent = "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:128.0) Gecko/20100101 Firefox/128.0"
8-
9-
# Check fragments in links
6+
# Check link anchors
107
include_fragments = true
118

129
# excluding links to pull requests and issues is done for performance

0 commit comments

Comments
 (0)