Skip to content

Commit 4d1d15e

Browse files
committed
Use JUL's formatted logging
1 parent cc8d663 commit 4d1d15e

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

gcp-auth-extension/src/main/java/io/opentelemetry/contrib/gcp/auth/GcpAuthAutoConfigurationCustomizerProvider.java

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,6 @@ public class GcpAuthAutoConfigurationCustomizerProvider
6060
ConfigurableOption.GOOGLE_OTEL_AUTH_TARGET_SIGNALS.getUserReadableName(),
6161
ConfigurableOption.GOOGLE_OTEL_AUTH_TARGET_SIGNALS.getEnvironmentVariable(),
6262
ConfigurableOption.GOOGLE_OTEL_AUTH_TARGET_SIGNALS.getSystemProperty());
63-
private static final String SIGNAL_TARGET_WARNING_MSG =
64-
"GCP Authentication Extension is not configured for signal type: %s. "
65-
+ SIGNAL_TARGET_WARNING_FIX_SUGGESTION;
6663

6764
static final String QUOTA_USER_PROJECT_HEADER = "x-goog-user-project";
6865
static final String GCP_USER_PROJECT_ID_KEY = "gcp.project_id";
@@ -125,7 +122,11 @@ private static SpanExporter customizeSpanExporter(
125122
if (isSignalTargeted(SIGNAL_TYPE_TRACES, configProperties)) {
126123
return addAuthorizationHeaders(exporter, credentials, configProperties);
127124
} else {
128-
logger.log(Level.WARNING, String.format(SIGNAL_TARGET_WARNING_MSG, SIGNAL_TYPE_TRACES));
125+
String[] params = {SIGNAL_TYPE_TRACES, SIGNAL_TARGET_WARNING_FIX_SUGGESTION};
126+
logger.log(
127+
Level.WARNING,
128+
"GCP Authentication Extension is not configured for signal type: {0}. {1}",
129+
params);
129130
}
130131
return exporter;
131132
}
@@ -135,7 +136,11 @@ private static MetricExporter customizeMetricExporter(
135136
if (isSignalTargeted(SIGNAL_TYPE_METRICS, configProperties)) {
136137
return addAuthorizationHeaders(exporter, credentials, configProperties);
137138
} else {
138-
logger.log(Level.WARNING, String.format(SIGNAL_TARGET_WARNING_MSG, SIGNAL_TYPE_METRICS));
139+
String[] params = {SIGNAL_TYPE_METRICS, SIGNAL_TARGET_WARNING_FIX_SUGGESTION};
140+
logger.log(
141+
Level.WARNING,
142+
"GCP Authentication Extension is not configured for signal type: {0}. {1}",
143+
params);
139144
}
140145
return exporter;
141146
}

0 commit comments

Comments
 (0)