Using daemon thread factory

Author: LikeTheSalad

opamp-client/src/main/java/io/opentelemetry/opamp/client/internal/request/service/DaemonThreadFactory.java

@@ -0,0 +1,20 @@
+package io.opentelemetry.opamp.client.internal.request.service;
+
+import java.util.concurrent.Executors;
+import java.util.concurrent.ThreadFactory;
+import javax.annotation.Nonnull;
+
+final class DaemonThreadFactory implements ThreadFactory {
+  private final ThreadFactory delegate = Executors.defaultThreadFactory();
+
+  @Override
+  public Thread newThread(@Nonnull Runnable r) {
+    Thread t = delegate.newThread(r);
+    try {
+      t.setDaemon(true);
+    } catch (SecurityException e) {
+      // Well, we tried.
+    }
+    return t;
+  }
+}

opamp-client/src/main/java/io/opentelemetry/opamp/client/internal/request/service/HttpRequestService.java

@@ -22,13 +22,11 @@
 import java.util.concurrent.Executors;
 import java.util.concurrent.ScheduledExecutorService;
 import java.util.concurrent.ScheduledFuture;
-import java.util.concurrent.ThreadFactory;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.TimeoutException;
 import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.concurrent.atomic.AtomicReference;
 import java.util.function.Supplier;
-import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 import opamp.proto.AgentToServer;
 import opamp.proto.ServerErrorResponse;
@@ -255,19 +253,4 @@ Duration getNextDelay() {
       return currentDelay.getNextDelay();
     }
   }
-
-  private static class DaemonThreadFactory implements ThreadFactory {
-    private final ThreadFactory delegate = Executors.defaultThreadFactory();
-
-    @Override
-    public Thread newThread(@Nonnull Runnable r) {
-      Thread t = delegate.newThread(r);
-      try {
-        t.setDaemon(true);
-      } catch (SecurityException e) {
-        // Well, we tried.
-      }
-      return t;
-    }
-  }
 }

opamp-client/src/main/java/io/opentelemetry/opamp/client/internal/request/service/WebSocketRequestService.java

@@ -64,7 +64,9 @@ public static WebSocketRequestService create(WebSocket webSocket) {
   public static WebSocketRequestService create(
       WebSocket webSocket, PeriodicDelay periodicRetryDelay) {
     return new WebSocketRequestService(
-        webSocket, periodicRetryDelay, Executors.newSingleThreadScheduledExecutor());
+        webSocket,
+        periodicRetryDelay,
+        Executors.newSingleThreadScheduledExecutor(new DaemonThreadFactory()));
   }
 
   WebSocketRequestService(