Skip to content

Commit 57f7988

Browse files
committed
fix jvm metrics scraper test
1 parent 6669305 commit 57f7988

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

jmx-scraper/src/integrationTest/java/io/opentelemetry/contrib/jmxscraper/target_systems/JvmIntegrationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,12 @@ protected JmxScraperContainer customizeScraperContainer(
3232
JmxScraperContainer scraper, GenericContainer<?> target, Path tempDir) {
3333
return scraper
3434
.withTargetSystem("jvm")
35-
// TODO when JVM metrics will be added to instrumentation, the default "auto" source
35+
// Since JVM metrics were be added to instrumentation, the default "auto" source
3636
// means that the definitions in instrumentation will be used, and thus this test will fail
3737
// due to metrics differences, adding an explicit "legacy" source is required to continue
3838
// testing the JVM metrics defined in this project.
3939
// https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/13392
40-
// .withTargetSystem("legacy")
40+
.withTargetSystemSource("legacy")
4141
// also testing custom yaml
4242
.withCustomYaml("custom-metrics.yaml");
4343
}

0 commit comments

Comments
 (0)