Skip to content

Commit 59e1e6f

Browse files
authored
Merge pull request #2 from SylvainJuge/fixed-port-for-cross-container
use fixed port for container-to-container
2 parents da8f4d8 + 2260258 commit 59e1e6f

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

jmx-scraper/src/integrationTest/java/io/opentelemetry/contrib/jmxscraper/target_systems/TargetSystemIntegrationTest.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,10 @@ public abstract class TargetSystemIntegrationTest {
5151

5252
private static final String OTLP_HOST = "host.testcontainers.internal";
5353

54+
// JMX communication only happens between container, and we don't have to use JMX
55+
// from host to container, we can use a fixed port.
56+
private static final int JMX_PORT = 9999;
57+
5458
@BeforeAll
5559
static void beforeAll() {
5660
network = Network.newNetwork();
@@ -85,10 +89,9 @@ void afterEach() {
8589

8690
@Test
8791
void endToEndTest() {
88-
int jmxPort = PortSelector.getAvailableRandomPort();
8992

9093
target =
91-
createTargetContainer(jmxPort)
94+
createTargetContainer(JMX_PORT)
9295
.withLogConsumer(new Slf4jLogConsumer(targetSystemLogger))
9396
.withNetwork(network)
9497
.withNetworkAliases(TARGET_SYSTEM_NETWORK_ALIAS);
@@ -98,7 +101,7 @@ void endToEndTest() {
98101
new JmxScraperContainer(otlpEndpoint)
99102
.withLogConsumer(new Slf4jLogConsumer(jmxScraperLogger))
100103
.withNetwork(network)
101-
.withService(TARGET_SYSTEM_NETWORK_ALIAS, jmxPort);
104+
.withService(TARGET_SYSTEM_NETWORK_ALIAS, JMX_PORT);
102105

103106
scraper = customizeScraperContainer(scraper);
104107
scraper.start();

0 commit comments

Comments
 (0)