Fix errorprone AssignmentExpression warning

laurit · laurit · commit 616f5a9be1c0 · 2025-03-21T09:52:06.000+02:00
diff --git a/jfr-connection/src/main/java/io/opentelemetry/contrib/jfr/connection/RecordingOptions.java b/jfr-connection/src/main/java/io/opentelemetry/contrib/jfr/connection/RecordingOptions.java
@@ -66,7 +66,8 @@ private enum Option {
 
   /* If the arg is null or an empty String, return the Option's default. */
   private static String normalize(String arg, Option option) {
-    return arg == null || (arg = arg.trim()).isEmpty() ? option.defaultValue : arg;
+    arg = arg == null ? "" : arg.trim();
+    return arg.isEmpty() ? option.defaultValue : arg;
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,8 @@ private enum Option {`
`66`	`66`
`67`	`67`	`/* If the arg is null or an empty String, return the Option's default. */`
`68`	`68`	`private static String normalize(String arg, Option option) {`
`69`		`- return arg == null \|\| (arg = arg.trim()).isEmpty() ? option.defaultValue : arg;`
	`69`	`+ arg = arg == null ? "" : arg.trim();`
	`70`	`+ return arg.isEmpty() ? option.defaultValue : arg;`
`70`	`71`	`}`
`71`	`72`
`72`	`73`	`/**`