Skip to content

Commit 6386bd8

Browse files
committed
pr feedback
1 parent 12c1df1 commit 6386bd8

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

.github/workflows/build.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,16 @@ on:
66
- main
77
- release/*
88
pull_request:
9+
merge_group:
910
workflow_dispatch:
1011

12+
permissions:
13+
contents: read
14+
1115
concurrency:
1216
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}
1317
cancel-in-progress: true
1418

15-
permissions:
16-
contents: read
17-
1819
jobs:
1920
build:
2021
runs-on: ubuntu-latest

inferred-spans/src/test/java/io/opentelemetry/contrib/inferredspans/InferredSpansAutoConfigTest.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
import static io.opentelemetry.sdk.testing.assertj.OpenTelemetryAssertions.assertThat;
99
import static org.awaitility.Awaitility.await;
10-
import static org.junit.jupiter.api.condition.OS.LINUX;
1110
import static org.junit.jupiter.api.condition.OS.WINDOWS;
1211

1312
import io.opentelemetry.api.GlobalOpenTelemetry;
@@ -33,10 +32,9 @@
3332
import org.junit.jupiter.api.BeforeEach;
3433
import org.junit.jupiter.api.Test;
3534
import org.junit.jupiter.api.condition.DisabledOnOs;
36-
import org.junit.jupiter.api.condition.EnabledOnOs;
3735
import org.junit.jupiter.api.io.TempDir;
3836

39-
@EnabledOnOs(LINUX) // Uses async-profiler, which is only supported on Linux
37+
@DisabledOnOs(WINDOWS) // Uses async-profiler, which is not supported on Windows
4038
public class InferredSpansAutoConfigTest {
4139

4240
@BeforeEach
@@ -110,7 +108,6 @@ public void checkDisabledbyDefault() {
110108
}
111109

112110
@DisabledOnOpenJ9
113-
@DisabledOnOs(WINDOWS)
114111
@Test
115112
public void checkProfilerWorking() {
116113
try (AutoConfigTestProperties props =

0 commit comments

Comments
 (0)