finally making it work !!

Author: SylvainJuge

jmx-scraper/src/integrationTest/java/io/opentelemetry/contrib/jmxscraper/target_systems/JettyIntegrationTest.java

@@ -5,8 +5,10 @@
 
 package io.opentelemetry.contrib.jmxscraper.target_systems;
 
+import static io.opentelemetry.contrib.jmxscraper.target_systems.MetricAssertions.assertGauge;
 import static io.opentelemetry.contrib.jmxscraper.target_systems.MetricAssertions.assertGaugeWithAttributes;
 import static io.opentelemetry.contrib.jmxscraper.target_systems.MetricAssertions.assertSumWithAttributes;
+import static io.opentelemetry.contrib.jmxscraper.target_systems.MetricAssertions.assertSumWithAttributesMultiplePoints;
 
 import io.opentelemetry.contrib.jmxscraper.JmxScraperContainer;
 import java.time.Duration;
@@ -72,28 +74,29 @@ protected void verifyMetrics() {
                 "The maximum amount of time a session has been active.",
                 "s",
                 attrs -> attrs.containsKey("resource")),
-//        metric ->
-//            assertSumWithAttributes(metric,
-//                "jetty.select.count",
-//                "The number of select calls.",
-//                "{operations}",
-//                // minor divergence from jetty.groovy with extra metrics attributes
-//                attrs -> attrs.containsKey("context"),
-//                attrs -> attrs.containsKey("id")
-//            ),
+        metric ->
+            assertSumWithAttributesMultiplePoints(metric,
+                "jetty.select.count",
+                "The number of select calls.",
+                "{operations}",
+                /* isMonotonic= */ true,
+                // minor divergence from jetty.groovy with extra metrics attributes
+                attrs -> attrs.containsKey("context").containsKey("id")
+            ),
         metric ->
             assertGaugeWithAttributes(
                 metric,
                 "jetty.thread.count",
                 "The current number of threads.",
                 "{threads}",
                 attrs -> attrs.containsEntry("state", "busy"),
-                attrs -> attrs.containsEntry("state", "idle"))/*,
+                attrs -> attrs.containsEntry("state", "idle")),
         metric ->
             assertGauge(
                 metric,
                 "jetty.thread.queue.count",
                 "The current number of threads in the queue.",
-                "{threads}")*/);
+                "{threads}"
+            ));
   }
 }

jmx-scraper/src/integrationTest/java/io/opentelemetry/contrib/jmxscraper/target_systems/MetricAssertions.java

@@ -92,6 +92,22 @@ static void assertSumWithAttributes(
     assertAttributedPoints(metric.getSum().getDataPointsList(), attributeGroupAssertions);
   }
 
+  @SafeVarargs
+  static void assertSumWithAttributesMultiplePoints(
+      Metric metric,
+      String name,
+      String description,
+      String unit,
+      boolean isMonotonic,
+      Consumer<MapAssert<String, String>>... attributeGroupAssertions) {
+    assertThat(metric.getName()).isEqualTo(name);
+    assertThat(metric.getDescription()).isEqualTo(description);
+    assertThat(metric.getUnit()).isEqualTo(unit);
+    assertThat(metric.hasSum()).isTrue();
+    assertThat(metric.getSum().getIsMonotonic()).isEqualTo(isMonotonic);
+    assertAttributedMultiplePoints(metric.getSum().getDataPointsList(), attributeGroupAssertions);
+  }
+
   @SafeVarargs
   static void assertGaugeWithAttributes(
       Metric metric,
@@ -127,6 +143,7 @@ private static void assertAttributedPoints(
         Arrays.stream(attributeGroupAssertions)
             .map(assertion -> (Consumer<Map<String, String>>) m -> assertion.accept(assertThat(m)))
             .toArray(Consumer[]::new);
+
     assertThat(points)
         .extracting(
             numberDataPoint ->
@@ -136,4 +153,19 @@ private static void assertAttributedPoints(
                             KeyValue::getKey, keyValue -> keyValue.getValue().getStringValue())))
         .satisfiesExactlyInAnyOrder(assertions);
   }
+
+  @SuppressWarnings("unchecked")
+  private static void assertAttributedMultiplePoints(
+      List<NumberDataPoint> points,
+      Consumer<MapAssert<String, String>>... attributeGroupAssertions) {
+
+    points.stream()
+        .map(NumberDataPoint::getAttributesList)
+        .forEach(kvList -> {
+          Map<String, String> kvMap = kvList.stream()
+              .collect(Collectors.toMap(KeyValue::getKey, kv -> kv.getValue().getStringValue()));
+          Arrays.stream(attributeGroupAssertions)
+              .forEach(assertion -> assertion.accept(assertThat(kvMap)));
+        });
+  }
 }

jmx-scraper/src/main/resources/jetty.yaml

@@ -2,20 +2,20 @@
 
 rules:
 
-#  - bean: org.eclipse.jetty.io:context=*,type=managedselector,id=*
-#    mapping:
-#      selectCount:
-#        metric: jetty.select.count
-#        type: counter
-#        unit: "{operations}"
-#        desc: The number of select calls.
-#        metricAttribute:
-#          # minor divergence from jetty.groovy allowing to avoid warnings
-#          # 'id' is a numerical value in [0,9] by default
-#          # 'context' is a high cardinality value like 'HTTP_1_1@7674f035' but likely stable for the
-#          # duration of the jetty process lifecycle
-#          context: param(context)
-#          id: param(id)
+  - bean: org.eclipse.jetty.io:context=*,type=managedselector,id=*
+    mapping:
+      selectCount:
+        metric: jetty.select.count
+        type: counter
+        unit: "{operations}"
+        desc: The number of select calls.
+        metricAttribute:
+          # minor divergence from jetty.groovy with extra attribute(s)
+          # 'id' is a numerical value in [0,9] by default
+          # 'context' is a high cardinality value like 'HTTP_1_1@7674f035' but likely stable for the
+          # duration of the jetty process lifecycle
+          context: param(context)
+          id: param(id)
 
   - bean: org.eclipse.jetty.server.session:context=*,type=sessionhandler,id=*
     prefix: jetty.session.
@@ -40,6 +40,7 @@ rules:
         desc: The maximum amount of time a session has been active.
 
   - bean: org.eclipse.jetty.util.thread:type=queuedthreadpool,id=*
+    # here the 'id' can be ignored as it's usually a single value equal to '0'
     prefix: jetty.thread.
     unit: "{threads}"
     mapping:
@@ -57,7 +58,8 @@ rules:
         desc: The current number of threads.
         metricAttribute:
           state: const(idle)
-#      queueSize:
-#        metric: queue.count
-#        # here an 'updowncounter' seems more appropriate but gauge reflects jetty.groovy impl.
-#        type: gauge
+      queueSize:
+        metric: queue.count
+        # here an 'updowncounter' seems more appropriate but gauge reflects jetty.groovy impl.
+        type: gauge
+        desc: The current number of threads in the queue.