leave profiler disabled in test

Author: zeitlinger

inferred-spans/src/main/java/io/opentelemetry/contrib/inferredspans/InferredSpansAutoConfig.java

@@ -60,6 +60,7 @@ static SpanProcessor create(ConfigProperties properties) {
 
     PropertiesApplier applier = new PropertiesApplier(properties);
 
+    applier.applyBool(ENABLED_OPTION, builder::profilerEnabled);
     applier.applyBool(LOGGING_OPTION, builder::profilerLoggingEnabled);
     applier.applyBool(DIAGNOSTIC_FILES_OPTION, builder::backupDiagnosticFiles);
     applier.applyInt(SAFEMODE_OPTION, builder::asyncProfilerSafeMode);

inferred-spans/src/main/java/io/opentelemetry/contrib/inferredspans/InferredSpansProcessorBuilder.java

@@ -19,6 +19,7 @@
 
 @SuppressWarnings("CanIgnoreReturnValueSuggester")
 public class InferredSpansProcessorBuilder {
+  private boolean enabled = true;
   private boolean profilerLoggingEnabled = true;
   private boolean backupDiagnosticFiles = false;
   private int asyncProfilerSafeMode = 0;
@@ -60,6 +61,7 @@ public class InferredSpansProcessorBuilder {
   public InferredSpansProcessor build() {
     InferredSpansConfiguration config =
         new InferredSpansConfiguration(
+            enabled,
             profilerLoggingEnabled,
             backupDiagnosticFiles,
             asyncProfilerSafeMode,
@@ -76,6 +78,11 @@ public InferredSpansProcessor build() {
         config, clock, startScheduledProfiling, activationEventsFile, jfrFile);
   }
 
+  public InferredSpansProcessorBuilder profilerEnabled(boolean profilerEnabled) {
+    this.enabled = profilerEnabled;
+    return this;
+  }
+
   /**
    * By default, async profiler prints warning messages about missing JVM symbols to standard
    * output. Set this option to {@code false} to suppress such messages.

inferred-spans/src/main/java/io/opentelemetry/contrib/inferredspans/internal/InferredSpansConfiguration.java

@@ -15,6 +15,7 @@
 
 public class InferredSpansConfiguration {
 
+  private final boolean enabled;
   private final boolean profilerLoggingEnabled;
   private final boolean backupDiagnosticFiles;
   private final int asyncProfilerSafeMode;
@@ -30,6 +31,7 @@ public class InferredSpansConfiguration {
 
   @SuppressWarnings("TooManyParameters")
   public InferredSpansConfiguration(
+      boolean enabled,
       boolean profilerLoggingEnabled,
       boolean backupDiagnosticFiles,
       int asyncProfilerSafeMode,
@@ -42,6 +44,7 @@ public InferredSpansConfiguration(
       Duration profilingDuration,
       @Nullable String profilerLibDirectory,
       BiConsumer<SpanBuilder, SpanContext> parentOverrideHandler) {
+    this.enabled = enabled;
     this.profilerLoggingEnabled = profilerLoggingEnabled;
     this.backupDiagnosticFiles = backupDiagnosticFiles;
     this.asyncProfilerSafeMode = asyncProfilerSafeMode;
@@ -56,6 +59,10 @@ public InferredSpansConfiguration(
     this.parentOverrideHandler = parentOverrideHandler;
   }
 
+  public boolean isEnabled() {
+    return enabled;
+  }
+
   public boolean isProfilingLoggingEnabled() {
     return profilerLoggingEnabled;
   }

inferred-spans/src/main/java/io/opentelemetry/contrib/inferredspans/internal/SamplingProfiler.java

@@ -354,6 +354,10 @@ public boolean onDeactivation(Span deactivatedSpan, @Nullable Span previouslyAct
   @Override
   @SuppressWarnings("FutureReturnValueIgnored")
   public void run() {
+    if (!config.isEnabled()) {
+      logger.fine("Profiling is disabled, not starting profiling session");
+      return;
+    }
 
     // lazily create temporary files
     try {

inferred-spans/src/test/java/io/opentelemetry/contrib/inferredspans/InferredSpansCustomizerProviderTest.java

@@ -33,6 +33,7 @@ void declarativeConfig() {
             + "tracer_provider:\n"
             + "  processors:\n"
             + "    - inferred_spans:\n"
+            + "        enabled: false\n"
             + "        backup:\n"
             + "          diagnostic:\n"
             + "            files: true\n";