Skip to content

Commit 66f487e

Browse files
Adopt asynchronous helpers in Cassandra target script (#21)
1 parent 4449284 commit 66f487e

File tree

4 files changed

+123
-249
lines changed

4 files changed

+123
-249
lines changed

contrib/jmx-metrics/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ otel.jmx.password = my-password
2828
def storageLoadMBean = otel.mbean("org.apache.cassandra.metrics:type=Storage,name=Load")
2929
otel.instrument(storageLoadMBean, "cassandra.storage.load",
3030
"Size, in bytes, of the on disk data size this node manages",
31-
"By", "Count", otel.&longValueRecorder
31+
"By", "Count", otel.&longValueObserver
3232
)
3333
```
3434

contrib/jmx-metrics/docs/target-systems/cassandra.md

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -10,118 +10,118 @@ These metrics are sourced from Cassandra's exposed Dropwizard Metrics for each n
1010
* Name: `cassandra.client.request.range_slice.latency.50p`
1111
* Description: Token range read request latency - 50th percentile
1212
* Unit: `µs`
13-
* Instrument Type: DoubleUpDownCounter
13+
* Instrument Type: DoubleValueObserver
1414

1515
* Name: `cassandra.client.request.range_slice.latency.99p`
1616
* Description: Token range read request latency - 99th percentile
1717
* Unit: `µs`
18-
* Instrument Type: DoubleUpDownCounter
18+
* Instrument Type: DoubleValueObserver
1919

2020
* Name: `cassandra.client.request.range_slice.latency.count`
2121
* Description: Total token range read request latency
2222
* Unit: `µs`
23-
* Instrument Type: LongCounter
23+
* Instrument Type: LongSumObserver
2424

2525
* Name: `cassandra.client.request.range_slice.latency.max`
2626
* Description: Maximum token range read request latency
2727
* Unit: `µs`
28-
* Instrument Type: DoubleUpDownCounter
28+
* Instrument Type: DoubleValueObserver
2929

3030
* Name: `cassandra.client.request.range_slice.timeout.count`
3131
* Description: Number of token range read request timeouts encountered
3232
* Unit: `1`
33-
* Instrument Type: LongCounter
33+
* Instrument Type: LongSumObserver
3434

3535
* Name: `cassandra.client.request.range_slice.unavailable.count`
3636
* Description: Number of token range read request unavailable exceptions encountered
3737
* Unit: `1`
38-
* Instrument Type: LongCounter
38+
* Instrument Type: LongSumObserver
3939

4040
* Name: `cassandra.client.request.read.latency.50p`
4141
* Description: Standard read request latency - 50th percentile
4242
* Unit: `µs`
43-
* Instrument Type: DoubleUpDownCounter
43+
* Instrument Type: DoubleValueObserver
4444

4545
* Name: `cassandra.client.request.read.latency.99p`
4646
* Description: Standard read request latency - 99th percentile
4747
* Unit: `µs`
48-
* Instrument Type: DoubleUpDownCounter
48+
* Instrument Type: DoubleValueObserver
4949

5050
* Name: `cassandra.client.request.read.latency.count`
5151
* Description: Total standard read request latency
5252
* Unit: `µs`
53-
* Instrument Type: LongCounter
53+
* Instrument Type: LongSumObserver
5454

5555
* Name: `cassandra.client.request.read.latency.max`
5656
* Description: Maximum standard read request latency
5757
* Unit: `µs`
58-
* Instrument Type: DoubleUpDownCounter
58+
* Instrument Type: DoubleValueObserver
5959

6060
* Name: `cassandra.client.request.read.timeout.count`
6161
* Description: Number of standard read request timeouts encountered
6262
* Unit: `1`
63-
* Instrument Type: LongCounter
63+
* Instrument Type: LongSumObserver
6464

6565
* Name: `cassandra.client.request.read.unavailable.count`
6666
* Description: Number of standard read request unavailable exceptions encountered
6767
* Unit: `1`
68-
* Instrument Type: LongCounter
68+
* Instrument Type: LongSumObserver
6969

7070
* Name: `cassandra.client.request.write.latency.50p`
7171
* Description: Regular write request latency - 50th percentile
7272
* Unit: `µs`
73-
* Instrument Type: DoubleUpDownCounter
73+
* Instrument Type: DoubleValueObserver
7474

7575
* Name: `cassandra.client.request.write.latency.99p`
7676
* Description: Regular write request latency - 99th percentile
7777
* Unit: `µs`
78-
* Instrument Type: DoubleUpDownCounter
78+
* Instrument Type: DoubleValueObserver
7979

8080
* Name: `cassandra.client.request.write.latency.count`
8181
* Description: Total regular write request latency
8282
* Unit: `µs`
83-
* Instrument Type: LongCounter
83+
* Instrument Type: LongSumObserver
8484

8585
* Name: `cassandra.client.request.write.latency.max`
8686
* Description: Maximum regular write request latency
8787
* Unit: `µs`
88-
* Instrument Type: DoubleUpDownCounter
88+
* Instrument Type: DoubleValueObserver
8989

9090
* Name: `cassandra.client.request.write.timeout.count`
9191
* Description: Number of regular write request timeouts encountered
9292
* Unit: `1`
93-
* Instrument Type: LongCounter
93+
* Instrument Type: LongSumObserver
9494

9595
* Name: `cassandra.client.request.write.unavailable.count`
9696
* Description: Number of regular write request unavailable exceptions encountered
9797
* Unit: `1`
98-
* Instrument Type: LongCounter
98+
* Instrument Type: LongSumObserver
9999

100100
### Compaction Metrics
101101

102102
* Name: `cassandra.compaction.tasks.completed`
103103
* Description: Number of completed compactions since server [re]start
104104
* Unit: `1`
105-
* Instrument Type: LongCounter
105+
* Instrument Type: LongSumObserver
106106

107107
* Name: `cassandra.compaction.tasks.pending`
108108
* Description: Estimated number of compactions remaining to perform
109109
* Unit: `1`
110-
* Instrument Type: LongUpDownCounter
110+
* Instrument Type: LongValueObserver
111111

112112
### Storage Metrics
113113

114114
* Name: `cassandra.storage.load.count`
115115
* Description: Size of the on disk data size this node manages
116116
* Unit: `by`
117-
* Instrument Type: LongUpDownCounter
117+
* Instrument Type: LongValueObserver
118118

119119
* Name: `cassandra.storage.total_hints.count`
120120
* Description: Number of hint messages written to this node since [re]start
121121
* Unit: `1`
122-
* Instrument Type: LongCounter
122+
* Instrument Type: LongSumObserver
123123

124124
* Name: `cassandra.storage.total_hints.in_progress.count`
125125
* Description: Number of hints attempting to be sent currently
126126
* Unit: `1`
127-
* Instrument Type: LongUpDownCounter
127+
* Instrument Type: LongValueObserver

0 commit comments

Comments
 (0)