Skip to content

Commit 685b189

Browse files
authored
Migrate from test-sets to test suites. (#214)
1 parent 66ecfdb commit 685b189

File tree

4 files changed

+43
-31
lines changed

4 files changed

+43
-31
lines changed

aws-xray/build.gradle.kts

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,10 @@
11
plugins {
22
id("otel.java-conventions")
33
id("otel.publish-conventions")
4-
5-
id("org.unbroken-dome.test-sets")
64
}
75

86
description = "OpenTelemetry AWS X-Ray Support"
97

10-
testSets {
11-
create("awsTest")
12-
}
13-
148
dependencies {
159
api("io.opentelemetry:opentelemetry-api")
1610
api("io.opentelemetry:opentelemetry-sdk-trace")
@@ -35,7 +29,17 @@ dependencies {
3529
testImplementation("com.google.guava:guava")
3630
testImplementation("org.slf4j:slf4j-simple")
3731
testImplementation("org.skyscreamer:jsonassert")
32+
}
3833

39-
add("awsTestImplementation", "io.opentelemetry:opentelemetry-exporter-otlp-trace")
40-
add("awsTestImplementation", "org.testcontainers:junit-jupiter")
34+
testing {
35+
suites {
36+
val awsTest by registering(JvmTestSuite::class) {
37+
dependencies {
38+
implementation("io.opentelemetry:opentelemetry-exporter-otlp-trace")
39+
implementation("io.opentelemetry:opentelemetry-sdk-testing")
40+
implementation("org.testcontainers:junit-jupiter")
41+
runtimeOnly("org.slf4j:slf4j-simple")
42+
}
43+
}
44+
}
4145
}

buildSrc/src/main/kotlin/otel.java-conventions.gradle.kts

Lines changed: 19 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -99,14 +99,25 @@ dependencies {
9999
}
100100

101101
compileOnly("com.google.code.findbugs:jsr305")
102+
}
103+
104+
testing {
105+
suites.withType(JvmTestSuite::class).configureEach {
106+
dependencies {
107+
implementation(project)
108+
109+
compileOnly("com.google.auto.value:auto-value-annotations")
110+
compileOnly("com.google.errorprone:error_prone_annotations")
111+
compileOnly("com.google.code.findbugs:jsr305")
102112

103-
testImplementation("org.assertj:assertj-core")
104-
testImplementation("org.awaitility:awaitility")
105-
testImplementation("org.junit.jupiter:junit-jupiter-api")
106-
testImplementation("org.junit.jupiter:junit-jupiter-params")
107-
testImplementation("org.mockito:mockito-core")
108-
testImplementation("org.mockito:mockito-junit-jupiter")
113+
implementation("org.junit.jupiter:junit-jupiter-api")
114+
implementation("org.junit.jupiter:junit-jupiter-params")
115+
implementation("org.mockito:mockito-core")
116+
implementation("org.mockito:mockito-junit-jupiter")
117+
implementation("org.assertj:assertj-core")
118+
implementation("org.awaitility:awaitility")
109119

110-
testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine")
111-
testRuntimeOnly("org.junit.vintage:junit-vintage-engine")
120+
runtimeOnly("org.junit.jupiter:junit-jupiter-engine")
121+
}
122+
}
112123
}

jmx-metrics/build.gradle.kts

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
plugins {
22
application
33
id("com.github.johnrengelman.shadow")
4-
id("org.unbroken-dome.test-sets")
54

65
id("otel.groovy-conventions")
76
id("otel.publish-conventions")
@@ -24,10 +23,6 @@ repositories {
2423

2524
val groovyVersion = "3.0.8"
2625

27-
testSets {
28-
create("integrationTest")
29-
}
30-
3126
dependencies {
3227
api(platform("org.codehaus.groovy:groovy-bom:$groovyVersion"))
3328

@@ -53,18 +48,21 @@ dependencies {
5348

5449
runtimeOnly("org.terracotta:jmxremote_optional-tc:1.0.8")
5550

56-
testImplementation("io.grpc:grpc-api")
57-
testImplementation("io.grpc:grpc-protobuf")
58-
testImplementation("io.grpc:grpc-stub")
59-
testImplementation("io.grpc:grpc-testing")
6051
testImplementation("org.junit-pioneer:junit-pioneer")
6152
testImplementation("org.awaitility:awaitility")
62-
testImplementation("org.testcontainers:testcontainers")
63-
testImplementation("io.opentelemetry.proto:opentelemetry-proto:0.11.0-alpha")
53+
}
6454

65-
add("integrationTestImplementation", "com.linecorp.armeria:armeria-grpc")
66-
add("integrationTestImplementation", "com.linecorp.armeria:armeria-junit5")
67-
add("integrationTestImplementation", "org.testcontainers:junit-jupiter")
55+
testing {
56+
suites {
57+
val integrationTest by registering(JvmTestSuite::class) {
58+
dependencies {
59+
implementation("com.linecorp.armeria:armeria-grpc")
60+
implementation("com.linecorp.armeria:armeria-junit5")
61+
implementation("io.opentelemetry.proto:opentelemetry-proto:0.11.0-alpha")
62+
implementation("org.testcontainers:junit-jupiter")
63+
}
64+
}
65+
}
6866
}
6967

7068
tasks {

settings.gradle.kts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ pluginManagement {
33
id("com.github.ben-manes.versions") version "0.39.0"
44
id("com.github.johnrengelman.shadow") version "7.1.1"
55
id("com.gradle.enterprise") version "3.8"
6-
id("org.unbroken-dome.test-sets") version "4.0.0"
76
id("io.github.gradle-nexus.publish-plugin") version "1.1.0"
87
id("nebula.release") version "16.0.0"
98
}

0 commit comments

Comments
 (0)