Skip to content

Commit 7743a2e

Browse files
committed
fix(disk-buffering): Add missing EventName to disk-buffering LogRecord data mapper
1 parent 0a37bb9 commit 7743a2e

File tree

4 files changed

+41
-0
lines changed

4 files changed

+41
-0
lines changed

disk-buffering/src/main/java/io/opentelemetry/contrib/disk/buffering/internal/serialization/mapping/logs/LogRecordDataMapper.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,9 @@ public LogRecord mapToProto(LogRecordData source) {
4747
if (source.getBodyValue() != null) {
4848
logRecord.body(bodyToAnyValue(source.getBodyValue()));
4949
}
50+
if (source.getEventName() != null) {
51+
logRecord.event_name(source.getEventName());
52+
}
5053

5154
byte flags = source.getSpanContext().getTraceFlags().asByte();
5255
logRecord.flags(toUnsignedInt(flags));
@@ -77,6 +80,9 @@ public LogRecordData mapToSdk(
7780
if (source.body != null) {
7881
logRecordData.setBodyValue(anyValueToBody(source.body));
7982
}
83+
if (source.event_name != null) {
84+
logRecordData.setEventName(source.event_name);
85+
}
8086

8187
addExtrasToSdkItemBuilder(source, logRecordData, resource, scopeInfo);
8288

disk-buffering/src/main/java/io/opentelemetry/contrib/disk/buffering/internal/serialization/mapping/logs/models/LogRecordDataImpl.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,10 @@ public ExtendedAttributes getExtendedAttributes() {
4646
@Nullable
4747
public abstract Value<?> getBodyValue();
4848

49+
@Override
50+
@Nullable
51+
public abstract String getEventName();
52+
4953
@AutoValue.Builder
5054
public abstract static class Builder {
5155
public abstract Builder setResource(Resource value);
@@ -68,6 +72,8 @@ public abstract static class Builder {
6872

6973
public abstract Builder setTotalAttributeCount(Integer value);
7074

75+
public abstract Builder setEventName(String value);
76+
7177
public abstract LogRecordDataImpl build();
7278
}
7379
}

disk-buffering/src/test/java/io/opentelemetry/contrib/disk/buffering/internal/serialization/mapping/logs/LogRecordDataMapperTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ class LogRecordDataMapperTest {
3131
.setTimestampEpochNanos(100L)
3232
.setObservedTimestampEpochNanos(200L)
3333
.setTotalAttributeCount(3)
34+
.setEventName("my.event.name")
3435
.build();
3536

3637
@Test

disk-buffering/src/test/java/io/opentelemetry/contrib/disk/buffering/internal/serialization/mapping/logs/ProtoLogsDataMapperTest.java

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,21 @@ class ProtoLogsDataMapperTest {
8181
.setTotalAttributeCount(3)
8282
.build();
8383

84+
private static final LogRecordData LOG_RECORD_WITH_EVENT_NAME =
85+
LogRecordDataImpl.builder()
86+
.setResource(TestData.RESOURCE_FULL)
87+
.setSpanContext(TestData.SPAN_CONTEXT)
88+
.setInstrumentationScopeInfo(TestData.INSTRUMENTATION_SCOPE_INFO_FULL)
89+
.setAttributes(TestData.ATTRIBUTES)
90+
.setBodyValue(Value.of("Log body"))
91+
.setSeverity(Severity.DEBUG)
92+
.setSeverityText("Log severity text")
93+
.setTimestampEpochNanos(100L)
94+
.setObservedTimestampEpochNanos(200L)
95+
.setTotalAttributeCount(3)
96+
.setEventName("test.event.name")
97+
.build();
98+
8499
@Test
85100
void verifyConversionDataStructure() {
86101
List<LogRecordData> signals = Collections.singletonList(LOG_RECORD);
@@ -160,6 +175,19 @@ void verifyMultipleLogsWithDifferentResource() {
160175
assertThat(mapFromProto(proto)).containsExactlyInAnyOrderElementsOf(signals);
161176
}
162177

178+
@Test
179+
void verifyLogWithEventName() {
180+
List<LogRecordData> signals = Collections.singletonList(LOG_RECORD_WITH_EVENT_NAME);
181+
182+
LogsData result = mapToProto(signals);
183+
184+
List<ResourceLogs> resourceLogsList = result.resource_logs;
185+
LogRecord firstLog = resourceLogsList.get(0).scope_logs.get(0).log_records.get(0);
186+
187+
assertEquals("test.event.name", firstLog.event_name);
188+
assertThat(mapFromProto(result)).containsExactlyInAnyOrderElementsOf(signals);
189+
}
190+
163191
private static LogsData mapToProto(Collection<LogRecordData> signals) {
164192
return ProtoLogsDataMapper.getInstance().toProto(signals);
165193
}

0 commit comments

Comments
 (0)