Calling callback.onConnectionFailed

Author: LikeTheSalad

opamp-client/src/main/java/io/opentelemetry/opamp/client/internal/request/service/HttpRequestService.java

@@ -141,19 +141,20 @@ private void doSendRequest() {
     CompletableFuture<HttpSender.Response> future =
         requestSender.send(outputStream -> outputStream.write(data), data.length);
     try (HttpSender.Response response = future.get(30, TimeUnit.SECONDS)) {
+      getCallback().onConnectionSuccess();
       if (isSuccessful(response)) {
         handleSuccessResponse(
             Response.create(ServerToAgent.ADAPTER.decode(response.bodyInputStream())));
       } else {
         handleHttpError(response);
       }
     } catch (IOException | InterruptedException | TimeoutException e) {
-      getCallback().onRequestFailed(e);
+      getCallback().onConnectionFailed(e);
     } catch (ExecutionException e) {
       if (e.getCause() != null) {
-        getCallback().onRequestFailed(e.getCause());
+        getCallback().onConnectionFailed(e.getCause());
       } else {
-        getCallback().onRequestFailed(e);
+        getCallback().onConnectionFailed(e);
       }
     }
   }

opamp-client/src/main/java/io/opentelemetry/opamp/client/internal/request/service/RequestService.java

@@ -50,7 +50,7 @@ interface Callback {
 
     /**
      * For WebSocket implementations, this is called when the connection cannot be made or is lost.
-     * For HTTP implementations, this is called on every HTTP request that fails.
+     * For HTTP implementations, this is called on every HTTP request that cannot get a response.
      *
      * @param throwable The detailed error.
      */

opamp-client/src/test/java/io/opentelemetry/opamp/client/internal/request/service/HttpRequestServiceTest.java

@@ -142,7 +142,7 @@ void verifySendingRequest_whenTheresAParsingError() {
     httpRequestService.run();
 
     verify(requestSender).send(any(), eq(requestSize));
-    verify(callback).onRequestFailed(any());
+    verify(callback).onConnectionFailed(any());
   }
 
   @Test
@@ -157,7 +157,7 @@ void verifySendingRequest_whenThereIsAnExecutionError()
     httpRequestService.run();
 
     verify(requestSender).send(any(), eq(requestSize));
-    verify(callback).onRequestFailed(myException);
+    verify(callback).onConnectionFailed(myException);
   }
 
   @Test
@@ -172,7 +172,7 @@ void verifySendingRequest_whenThereIsAnInterruptedException()
     httpRequestService.run();
 
     verify(requestSender).send(any(), eq(requestSize));
-    verify(callback).onRequestFailed(myException);
+    verify(callback).onConnectionFailed(myException);
   }
 
   @Test