Skip to content

Commit 83b4c54

Browse files
committed
Describing websocket close code
1 parent cf26a64 commit 83b4c54

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

opamp-client/src/main/java/io/opentelemetry/opamp/client/internal/request/service/WebSocketRequestService.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,9 @@ public final class WebSocketRequestService implements RequestService, WebSocket.
3939
public static final PeriodicDelay DEFAULT_DELAY_BETWEEN_RETRIES =
4040
PeriodicDelay.ofFixedDuration(Duration.ofSeconds(30));
4141

42+
/** Defined <a href="https://datatracker.ietf.org/doc/html/rfc6455#section-7.4.1">here</a>. */
43+
private static final int WEBSOCKET_NORMAL_CLOSURE_CODE = 1000;
44+
4245
@GuardedBy("hasPendingRequestLock")
4346
private boolean hasPendingRequest = false;
4447

@@ -138,7 +141,7 @@ private Request getRequest() {
138141
public void stop() {
139142
if (hasStopped.compareAndSet(false, true)) {
140143
doSendRequest();
141-
webSocket.close(1000, null);
144+
webSocket.close(WEBSOCKET_NORMAL_CLOSURE_CODE, null);
142145
executorService.shutdown();
143146
}
144147
}
@@ -190,7 +193,7 @@ private void handleServerError(ServerErrorResponse errorResponse) {
190193
retryAfter = Duration.ofNanos(errorResponse.retry_info.retry_after_nanoseconds);
191194
}
192195

193-
webSocket.close(1000, null);
196+
webSocket.close(WEBSOCKET_NORMAL_CLOSURE_CODE, null);
194197
scheduleConnectionRetry(retryAfter);
195198
}
196199
}

0 commit comments

Comments
 (0)