Skip to content

Commit 9392780

Browse files
SylvainJugeSylvainJuge
committed
refactor cassandra
1 parent 9c3390c commit 9392780

File tree

1 file changed

+125
-59
lines changed

1 file changed

+125
-59
lines changed

‎jmx-scraper/src/integrationTest/java/io/opentelemetry/contrib/jmxscraper/target_systems/CassandraIntegrationTest.java‎

Lines changed: 125 additions & 59 deletions
Original file line numberDiff line numberDiff line change
@@ -39,80 +39,146 @@ protected JmxScraperContainer customizeScraperContainer(
3939
@Override
4040
protected MetricsVerifier createMetricsVerifier() {
4141
return MetricsVerifier.create()
42-
.assertGauge(
42+
.add(
4343
"cassandra.client.request.range_slice.latency.50p",
44-
"Token range read request latency - 50th percentile",
45-
"us")
46-
.assertGauge(
44+
metric ->
45+
metric
46+
.hasDescription("Token range read request latency - 50th percentile")
47+
.hasUnit("us")
48+
.isGauge()
49+
.hasDataPointsWithoutAttributes())
50+
.add(
4751
"cassandra.client.request.range_slice.latency.99p",
48-
"Token range read request latency - 99th percentile",
49-
"us")
50-
.assertGauge(
52+
metric ->
53+
metric
54+
.hasDescription("Token range read request latency - 99th percentile")
55+
.hasUnit("us")
56+
.isGauge()
57+
.hasDataPointsWithoutAttributes())
58+
.add(
5159
"cassandra.client.request.range_slice.latency.max",
52-
"Maximum token range read request latency",
53-
"us")
54-
.assertGauge(
60+
metric ->
61+
metric
62+
.hasDescription("Maximum token range read request latency")
63+
.hasUnit("us")
64+
.isGauge()
65+
.hasDataPointsWithoutAttributes())
66+
.add(
5567
"cassandra.client.request.read.latency.50p",
56-
"Standard read request latency - 50th percentile",
57-
"us")
58-
.assertGauge(
68+
metric ->
69+
metric
70+
.hasDescription("Standard read request latency - 50th percentile")
71+
.hasUnit("us")
72+
.isGauge()
73+
.hasDataPointsWithoutAttributes())
74+
.add(
5975
"cassandra.client.request.read.latency.99p",
60-
"Standard read request latency - 99th percentile",
61-
"us")
62-
.assertGauge(
76+
metric ->
77+
metric
78+
.hasDescription("Standard read request latency - 99th percentile")
79+
.hasUnit("us")
80+
.isGauge()
81+
.hasDataPointsWithoutAttributes())
82+
.add(
6383
"cassandra.client.request.read.latency.max",
64-
"Maximum standard read request latency",
65-
"us")
66-
.assertGauge(
84+
metric ->
85+
metric
86+
.hasDescription("Maximum standard read request latency")
87+
.hasUnit("us")
88+
.isGauge()
89+
.hasDataPointsWithoutAttributes())
90+
.add(
6791
"cassandra.client.request.write.latency.50p",
68-
"Regular write request latency - 50th percentile",
69-
"us")
70-
.assertGauge(
92+
metric ->
93+
metric
94+
.hasDescription("Regular write request latency - 50th percentile")
95+
.hasUnit("us")
96+
.isGauge()
97+
.hasDataPointsWithoutAttributes())
98+
.add(
7199
"cassandra.client.request.write.latency.99p",
72-
"Regular write request latency - 99th percentile",
73-
"us")
74-
.assertGauge(
100+
metric ->
101+
metric
102+
.hasDescription("Regular write request latency - 99th percentile")
103+
.hasUnit("us")
104+
.isGauge()
105+
.hasDataPointsWithoutAttributes())
106+
.add(
75107
"cassandra.client.request.write.latency.max",
76-
"Maximum regular write request latency",
77-
"us")
78-
.assertCounter(
108+
metric ->
109+
metric
110+
.hasDescription("Maximum regular write request latency")
111+
.hasUnit("us")
112+
.isGauge()
113+
.hasDataPointsWithoutAttributes())
114+
.add(
79115
"cassandra.compaction.tasks.completed",
80-
"Number of completed compactions since server [re]start",
81-
"1")
82-
.assertGauge(
116+
metric ->
117+
metric
118+
.hasDescription("Number of completed compactions since server [re]start")
119+
.hasUnit("1")
120+
.isCounter()
121+
.hasDataPointsWithoutAttributes())
122+
.add(
83123
"cassandra.compaction.tasks.pending",
84-
"Estimated number of compactions remaining to perform",
85-
"1")
86-
.assertUpDownCounter(
87-
"cassandra.storage.load.count", "Size of the on disk data size this node manages", "by")
88-
.assertCounter(
124+
metric ->
125+
metric
126+
.hasDescription("Estimated number of compactions remaining to perform")
127+
.hasUnit("1")
128+
.isGauge()
129+
.hasDataPointsWithoutAttributes())
130+
.add(
131+
"cassandra.storage.load.count",
132+
metric ->
133+
metric
134+
.hasDescription("Size of the on disk data size this node manages")
135+
.hasUnit("by")
136+
.isUpDownCounter()
137+
.hasDataPointsWithoutAttributes())
138+
.add(
89139
"cassandra.storage.total_hints.count",
90-
"Number of hint messages written to this node since [re]start",
91-
"1")
92-
.assertUpDownCounter(
140+
metric ->
141+
metric
142+
.hasDescription("Number of hint messages written to this node since [re]start")
143+
.hasUnit("1")
144+
.isCounter()
145+
.hasDataPointsWithoutAttributes())
146+
.add(
93147
"cassandra.storage.total_hints.in_progress.count",
94-
"Number of hints attempting to be sent currently",
95-
"1")
96-
.assertCounterWithAttributes(
148+
metric ->
149+
metric
150+
.hasDescription("Number of hints attempting to be sent currently")
151+
.hasUnit("1")
152+
.isUpDownCounter()
153+
.hasDataPointsWithoutAttributes())
154+
.add(
97155
"cassandra.client.request.count",
98-
"Number of requests by operation",
99-
"1",
100-
requestCountAttributes("RangeSlice"),
101-
requestCountAttributes("Read"),
102-
requestCountAttributes("Write"))
103-
.assertCounterWithAttributes(
156+
metric ->
157+
metric
158+
.hasDescription("Number of requests by operation")
159+
.hasUnit("1")
160+
.isCounter()
161+
.hasDataPointsAttributes(
162+
requestCountAttributes("RangeSlice"),
163+
requestCountAttributes("Read"),
164+
requestCountAttributes("Write")))
165+
.add(
104166
"cassandra.client.request.error.count",
105-
"Number of request errors by operation",
106-
"1",
107-
errorCountAttributes("RangeSlice", "Timeout"),
108-
errorCountAttributes("RangeSlice", "Failure"),
109-
errorCountAttributes("RangeSlice", "Unavailable"),
110-
errorCountAttributes("Read", "Timeout"),
111-
errorCountAttributes("Read", "Failure"),
112-
errorCountAttributes("Read", "Unavailable"),
113-
errorCountAttributes("Write", "Timeout"),
114-
errorCountAttributes("Write", "Failure"),
115-
errorCountAttributes("Write", "Unavailable"));
167+
metric ->
168+
metric
169+
.hasDescription("Number of request errors by operation")
170+
.hasUnit("1")
171+
.isCounter()
172+
.hasDataPointsAttributes(
173+
errorCountAttributes("RangeSlice", "Timeout"),
174+
errorCountAttributes("RangeSlice", "Failure"),
175+
errorCountAttributes("RangeSlice", "Unavailable"),
176+
errorCountAttributes("Read", "Timeout"),
177+
errorCountAttributes("Read", "Failure"),
178+
errorCountAttributes("Read", "Unavailable"),
179+
errorCountAttributes("Write", "Timeout"),
180+
errorCountAttributes("Write", "Failure"),
181+
errorCountAttributes("Write", "Unavailable")));
116182
}
117183

118184
private static Map<String, String> errorCountAttributes(String operation, String status) {

0 commit comments

Comments
 (0)