Skip to content

Commit a2a1c96

Browse files
committed
add comment about incorrect metrics
1 parent 3aba726 commit a2a1c96

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

jmx-scraper/src/main/resources/jetty.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ rules:
77
selectCount:
88
metric: jetty.select.count
99
type: counter
10+
# Unit should not use a plural form, left as-is for compatibility with jetty.groovy
11+
# https://opentelemetry.io/docs/specs/semconv/general/metrics/#instrument-units
1012
unit: "{operations}"
1113
desc: The number of select calls.
1214
metricAttribute:
@@ -25,6 +27,8 @@ rules:
2527
sessionsCreated:
2628
metric: count
2729
type: counter
30+
# Unit should not use a plural form, left as-is for compatibility with jetty.groovy
31+
# https://opentelemetry.io/docs/specs/semconv/general/metrics/#instrument-units
2832
unit: "{sessions}"
2933
desc: The number of sessions established in total.
3034
sessionTimeTotal:
@@ -42,6 +46,8 @@ rules:
4246
- bean: org.eclipse.jetty.util.thread:type=queuedthreadpool,id=*
4347
# here the 'id' can be ignored as it's usually a single value equal to '0'
4448
prefix: jetty.thread.
49+
# Unit should not use a plural form, left as-is for compatibility with jetty.groovy
50+
# https://opentelemetry.io/docs/specs/semconv/general/metrics/#instrument-units
4551
unit: "{threads}"
4652
mapping:
4753
busyThreads:

0 commit comments

Comments
 (0)