add method to generate generic jmx args

Author: SylvainJuge

jmx-scraper/src/integrationTest/java/io/opentelemetry/contrib/jmxscraper/target_systems/TargetSystemIntegrationTest.java

@@ -22,7 +22,9 @@
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collection;
+import java.util.HashMap;
 import java.util.List;
+import java.util.Map;
 import java.util.concurrent.BlockingQueue;
 import java.util.concurrent.ExecutionException;
 import java.util.concurrent.LinkedBlockingDeque;
@@ -196,4 +198,27 @@ public void export(
       sb.http(0);
     }
   }
+
+  protected static String genericJmxJvmArguments(int port) {
+    Map<String, Object> args = new HashMap<>();
+    args.put("com.sun.management.jmxremote.local.only", "false");
+    args.put("com.sun.management.jmxremote.authenticate", "false");
+    args.put("com.sun.management.jmxremote.ssl", "false");
+    args.put("com.sun.management.jmxremote.port", port);
+    args.put("com.sun.management.jmxremote.rmi.port", port);
+    List<String> list =
+        args.entrySet().stream()
+            .map((e) -> toJvmArg(e.getKey(), e.getValue()))
+            .collect(Collectors.toList());
+    return String.join(" ", list);
+  }
+
+  private static String toJvmArg(String key, Object value) {
+    StringBuilder sb = new StringBuilder();
+    sb.append("-D").append(key);
+    if (value != null) {
+      sb.append("=").append(value);
+    }
+    return sb.toString();
+  }
 }

jmx-scraper/src/integrationTest/java/io/opentelemetry/contrib/jmxscraper/target_systems/TomcatIntegrationTest.java

@@ -31,15 +31,7 @@ protected GenericContainer<?> createTargetContainer(int jmxPort) {
                                 "/usr/local/tomcat/webapps/ROOT.war")
                             .build()))
         .withEnv("LOCAL_JMX", "no")
-        .withEnv(
-            "CATALINA_OPTS",
-            "-Dcom.sun.management.jmxremote.local.only=false"
-                + " -Dcom.sun.management.jmxremote.authenticate=false"
-                + " -Dcom.sun.management.jmxremote.ssl=false"
-                + " -Dcom.sun.management.jmxremote.port="
-                + jmxPort
-                + " -Dcom.sun.management.jmxremote.rmi.port="
-                + jmxPort)
+        .withEnv("CATALINA_OPTS", genericJmxJvmArguments(jmxPort))
         .withStartupTimeout(Duration.ofMinutes(2))
         .waitingFor(Wait.forListeningPort());
   }