Skip to content

Commit baeb2ed

Browse files
committed
fix version resolution for semconv
1 parent 83a195d commit baeb2ed

File tree

5 files changed

+15
-11
lines changed

5 files changed

+15
-11
lines changed

azure-resources/src/main/java/io/opentelemetry/contrib/azure/resource/IncubatingAttributes.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ final class IncubatingAttributes {
2424
AttributeKey.stringKey("cloud.resource_id");
2525

2626
public static final class CloudPlatformIncubatingValues {
27-
public static final String AZURE_VM = "azure_vm";
28-
public static final String AZURE_AKS = "azure_aks";
29-
public static final String AZURE_FUNCTIONS = "azure_functions";
30-
public static final String AZURE_APP_SERVICE = "azure_app_service";
27+
public static final String AZURE_VM = "azure.vm";
28+
public static final String AZURE_AKS = "azure.aks";
29+
public static final String AZURE_FUNCTIONS = "azure.functions";
30+
public static final String AZURE_APP_SERVICE = "azure.app_service";
3131

3232
private CloudPlatformIncubatingValues() {}
3333
}

azure-resources/src/test/java/io/opentelemetry/contrib/azure/resource/AzureAppServiceResourceProviderTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ void defaultValues() {
4848
createResource(DEFAULT_ENV_VARS)
4949
.containsEntry(SERVICE_NAME, TEST_WEBSITE_SITE_NAME)
5050
.containsEntry(CLOUD_PROVIDER, "azure")
51-
.containsEntry(CLOUD_PLATFORM, "azure_app_service")
51+
.containsEntry(CLOUD_PLATFORM, "azure.app_service")
5252
.containsEntry(
5353
CLOUD_RESOURCE_ID,
5454
"/subscriptions/TEST_WEBSITE_OWNER_NAME/resourceGroups/TEST_WEBSITE_RESOURCE_GROUP/providers/Microsoft.Web/sites/TEST_WEBSITE_SITE_NAME")

azure-resources/src/test/java/io/opentelemetry/contrib/azure/resource/AzureFunctionsResourceProviderTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ class AzureFunctionsResourceProviderTest {
3838
void defaultValues() {
3939
createResource(DEFAULT_ENV_VARS)
4040
.containsEntry(CLOUD_PROVIDER, "azure")
41-
.containsEntry(CLOUD_PLATFORM, "azure_functions")
41+
.containsEntry(CLOUD_PLATFORM, "azure.functions")
4242
.containsEntry(FAAS_NAME, TEST_WEBSITE_SITE_NAME)
4343
.containsEntry(FAAS_VERSION, TEST_FUNCTION_VERSION)
4444
.containsEntry(FAAS_INSTANCE, TEST_WEBSITE_INSTANCE_ID)

buildSrc/src/main/kotlin/otel.java-conventions.gradle.kts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ base.archivesName.set("opentelemetry-${project.name}")
1919

2020
// Version to use to compile code and run tests.
2121
val DEFAULT_JAVA_VERSION = JavaVersion.VERSION_17
22+
val semconvVersion = "1.37.0"
2223

2324
java {
2425
toolchain {
@@ -77,7 +78,7 @@ tasks {
7778
exceptionFormat = TestExceptionFormat.FULL
7879
showStandardStreams = true
7980
}
80-
81+
8182
configure<JacocoTaskExtension> {
8283
// only care about code coverage for code in this repository
8384
// (in particular avoiding netty classes which sometimes end up
@@ -145,6 +146,13 @@ dependencies {
145146
compileOnly("com.google.errorprone:error_prone_annotations")
146147
}
147148

149+
configurations.all {
150+
resolutionStrategy {
151+
force("io.opentelemetry.semconv:opentelemetry-semconv:${semconvVersion}")
152+
force("io.opentelemetry.semconv:opentelemetry-semconv-incubating:${semconvVersion}-alpha")
153+
}
154+
}
155+
148156
testing {
149157
suites.withType(JvmTestSuite::class).configureEach {
150158
dependencies {

dependencyManagement/build.gradle.kts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ plugins {
33
}
44

55
val otelInstrumentationVersion = "2.19.0-alpha"
6-
val semconvVersion = "1.37.0"
76

87
javaPlatform {
98
allowDependencies()
@@ -20,9 +19,6 @@ dependencies {
2019
api(enforcedPlatform("com.squareup.okhttp3:okhttp-bom:5.1.0"))
2120

2221
constraints {
23-
api("io.opentelemetry.semconv:opentelemetry-semconv:${semconvVersion}")
24-
api("io.opentelemetry.semconv:opentelemetry-semconv-incubating:${semconvVersion}")
25-
2622
api("com.google.auto.service:auto-service:1.1.1")
2723
api("com.google.auto.service:auto-service-annotations:1.1.1")
2824
api("com.google.auto.value:auto-value:1.11.0")

0 commit comments

Comments
 (0)