Skip to content

Commit cb50413

Browse files
committed
Improve containers startup and increase max duration of test
1 parent 5257aa0 commit cb50413

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

jmx-scraper/src/integrationTest/java/io/opentelemetry/contrib/jmxscraper/target_systems/TargetSystemIntegrationTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -111,13 +111,13 @@ void endToEndTest(@TempDir Path tmpDir) {
111111
.withLogConsumer(new Slf4jLogConsumer(targetSystemLogger))
112112
.withNetwork(network)
113113
.withNetworkAliases(TARGET_SYSTEM_NETWORK_ALIAS);
114-
target.start();
115114

116115
scraper =
117116
new JmxScraperContainer(otlpEndpoint, scraperBaseImage())
118117
.withLogConsumer(new Slf4jLogConsumer(jmxScraperLogger))
119118
.withNetwork(network)
120-
.withRmiServiceUrl(TARGET_SYSTEM_NETWORK_ALIAS, JMX_PORT);
119+
.withRmiServiceUrl(TARGET_SYSTEM_NETWORK_ALIAS, JMX_PORT)
120+
.dependsOn(target);
121121

122122
scraper = customizeScraperContainer(scraper, target, tmpDir);
123123
scraper.start();
@@ -167,7 +167,7 @@ protected final void waitAndAssertMetrics(Consumer<Metric>... assertions) {
167167
protected void verifyMetrics() {
168168
MetricsVerifier metricsVerifier = createMetricsVerifier();
169169
await()
170-
.atMost(Duration.ofSeconds(30))
170+
.atMost(Duration.ofSeconds(60))
171171
.untilAsserted(
172172
() -> {
173173
List<ExportMetricsServiceRequest> receivedMetrics = otlpServer.getMetrics();

0 commit comments

Comments
 (0)