Update errorProneVersion to v2.30.0 (#1408)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Jason Plumb <[email protected]>

Author: renovate[bot]

consistent-sampling/src/main/java/io/opentelemetry/contrib/sampler/consistent/ConsistentProbabilityBasedSampler.java

@@ -5,6 +5,7 @@
 
 package io.opentelemetry.contrib.sampler.consistent;
 
+import java.util.Locale;
 import javax.annotation.concurrent.Immutable;
 
 /** A consistent sampler that samples with a fixed probability. */
@@ -32,7 +33,7 @@ final class ConsistentProbabilityBasedSampler extends ConsistentSampler {
       throw new IllegalArgumentException("Sampling probability must be in range [0.0, 1.0]!");
     }
     this.description =
-        String.format("ConsistentProbabilityBasedSampler{%.6f}", samplingProbability);
+        String.format(Locale.ROOT, "ConsistentProbabilityBasedSampler{%.6f}", samplingProbability);
     this.randomGenerator = randomGenerator;
 
     lowerPValue = getLowerBoundP(samplingProbability);

consistent-sampling/src/main/java/io/opentelemetry/contrib/sampler/consistent/ConsistentRateLimitingSampler.java

@@ -8,6 +8,7 @@
 import static java.util.Objects.requireNonNull;
 
 import io.opentelemetry.sdk.trace.samplers.Sampler;
+import java.util.Locale;
 import java.util.concurrent.atomic.AtomicReference;
 import java.util.function.LongSupplier;
 import javax.annotation.concurrent.Immutable;
@@ -113,8 +114,10 @@ public State(double effectiveWindowCount, double effectiveWindowNanos, long last
     }
     this.description =
         String.format(
+            Locale.ROOT,
             "ConsistentRateLimitingSampler{%.6f, %.6f}",
-            targetSpansPerSecondLimit, adaptationTimeSeconds);
+            targetSpansPerSecondLimit,
+            adaptationTimeSeconds);
     this.nanoTimeSupplier = requireNonNull(nanoTimeSupplier);
 
     this.inverseAdaptationTimeNanos = 1e-9 / adaptationTimeSeconds;

dependencyManagement/build.gradle.kts

@@ -19,7 +19,7 @@ val DEPENDENCY_BOMS = listOf(
 
 val autoServiceVersion = "1.1.1"
 val autoValueVersion = "1.11.0"
-val errorProneVersion = "2.29.2"
+val errorProneVersion = "2.30.0"
 val prometheusVersion = "0.16.0"
 val mockitoVersion = "4.11.0"
 val slf4jVersion = "2.0.16"

inferred-spans/src/main/java/io/opentelemetry/contrib/inferredspans/internal/SamplingProfiler.java

@@ -36,6 +36,7 @@
 import java.util.Collections;
 import java.util.Date;
 import java.util.List;
+import java.util.Locale;
 import java.util.Objects;
 import java.util.concurrent.Executors;
 import java.util.concurrent.ScheduledExecutorService;
@@ -563,7 +564,7 @@ public void processTraces() throws IOException {
 
   @SuppressWarnings("JavaUtilDate")
   private void backupDiagnosticFiles(long eof) throws IOException {
-    String now = String.format("%tFT%<tT.%<tL", new Date());
+    String now = String.format(Locale.ROOT, "%tFT%<tT.%<tL", new Date());
     Path profilerDir = Paths.get(System.getProperty("java.io.tmpdir"), "profiler");
     profilerDir.toFile().mkdir();
 

inferred-spans/src/main/java/io/opentelemetry/contrib/inferredspans/internal/asyncprofiler/BufferedFile.java

@@ -14,6 +14,7 @@
 import java.nio.channels.FileChannel;
 import java.nio.charset.StandardCharsets;
 import java.nio.file.StandardOpenOption;
+import java.util.Locale;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 import javax.annotation.Nullable;
@@ -243,7 +244,10 @@ public void ensureRemaining(int minRemaining, int maxRead) throws IOException {
     if (minRemaining > buffer.capacity()) {
       throw new IllegalStateException(
           String.format(
-              "Length (%d) greater than buffer capacity (%d)", minRemaining, buffer.capacity()));
+              Locale.ROOT,
+              "Length (%d) greater than buffer capacity (%d)",
+              minRemaining,
+              buffer.capacity()));
     }
     if (buffer.remaining() < minRemaining) {
       read(position(), maxRead);

inferred-spans/src/main/java/io/opentelemetry/contrib/inferredspans/internal/asyncprofiler/JfrParser.java

@@ -14,6 +14,7 @@
 import java.util.Arrays;
 import java.util.HashSet;
 import java.util.List;
+import java.util.Locale;
 import java.util.Objects;
 import java.util.Set;
 import java.util.logging.Level;
@@ -114,7 +115,7 @@ private int readChunk(int position) throws IOException {
     short minor = bufferedFile.getShort();
     if (major != 2 || minor != 0) {
       throw new IllegalArgumentException(
-          String.format("Can only parse version 2.0. Was %d.%d", major, minor));
+          String.format(Locale.ROOT, "Can only parse version 2.0. Was %d.%d", major, minor));
     }
     long chunkSize = bufferedFile.getLong();
     long constantPoolOffset = bufferedFile.getLong();

jfr-connection/src/main/java/io/opentelemetry/contrib/jfr/connection/Recording.java

@@ -9,6 +9,7 @@
 import java.io.InputStream;
 import java.text.MessageFormat;
 import java.time.Instant;
+import java.util.Locale;
 import java.util.Objects;
 import java.util.concurrent.atomic.AtomicReference;
 import javax.annotation.Nullable;
@@ -54,7 +55,7 @@ public enum State {
   // {0} is the state the code is trying to transition to.
   // {1} are the states that the instance could be in for a valid transition.
   private static final MessageFormat illegalStateFormat =
-      new MessageFormat("Recording state {0} not in [{1}]");
+      new MessageFormat("Recording state {0} not in [{1}]", Locale.ROOT);
 
   /**
    * Helper for formatting the message for an IllegalStateException that may be thrown by methods of