spotless

Author: SylvainJuge

jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/config/JmxScraperConfig.java

@@ -150,8 +150,11 @@ public static JmxScraperConfig fromConfig(ConfigProperties config) {
     // providing compatibility with the deprecated 'otel.jmx.custom.scraping.config' config option
     String jmxConfigDeprecated = config.getString(JMX_CONFIG_LEGACY);
     if (jmxConfigDeprecated != null) {
-      logger.warning(JMX_CONFIG_LEGACY + " deprecated option is used, replacing with '" + JMX_CONFIG
-          + "' is recommended");
+      logger.warning(
+          JMX_CONFIG_LEGACY
+              + " deprecated option is used, replacing with '"
+              + JMX_CONFIG
+              + "' is recommended");
       List<String> list = new ArrayList<>(jmxConfig);
       list.add(jmxConfigDeprecated);
       jmxConfig = list;

jmx-scraper/src/test/java/io/opentelemetry/contrib/jmxscraper/config/JmxScraperConfigTest.java

@@ -64,11 +64,11 @@ void shouldPassValidation() {
 
   @ParameterizedTest(name = "custom yaml = {arguments}")
   @ValueSource(booleans = {true, false})
-  public void shouldCreateMinimalValidConfiguration(boolean customYaml){
+  public void shouldCreateMinimalValidConfiguration(boolean customYaml) {
     // Given
     Properties properties = new Properties();
     properties.setProperty(JMX_SERVICE_URL, "jservice:jmx:rmi:///jndi/rmi://localhost:9010/jmxrmi");
-    if(customYaml){
+    if (customYaml) {
       properties.setProperty(JMX_CONFIG, "/file.yaml");
     } else {
       properties.setProperty(JMX_TARGET_SYSTEM, "tomcat");
@@ -81,15 +81,14 @@ public void shouldCreateMinimalValidConfiguration(boolean customYaml){
     assertThat(config.getServiceUrl())
         .isEqualTo("jservice:jmx:rmi:///jndi/rmi://localhost:9010/jmxrmi");
 
-    if(customYaml){
+    if (customYaml) {
       assertThat(config.getJmxConfig()).containsExactly("/file.yaml");
       assertThat(config.getTargetSystems()).isEmpty();
     } else {
       assertThat(config.getJmxConfig()).isEmpty();
       assertThat(config.getTargetSystems()).containsExactly("tomcat");
     }
 
-
     assertThat(config.getSamplingInterval())
         .describedAs("default sampling interval must align to default metric export interval")
         .isEqualTo(Duration.ofMinutes(1));
@@ -136,8 +135,7 @@ void shouldFailValidation_missingConfigPathAndTargetSystem() {
     // When and Then
     assertThatThrownBy(() -> fromConfig(TestUtil.configProperties(properties)))
         .isInstanceOf(ConfigurationException.class)
-        .hasMessage(
-            "at least one of 'otel.jmx.target.system' or 'otel.jmx.config' must be set");
+        .hasMessage("at least one of 'otel.jmx.target.system' or 'otel.jmx.config' must be set");
   }
 
   @Test