Skip to content

Commit dc7f2a9

Browse files
committed
Using onClosing
1 parent b371629 commit dc7f2a9

File tree

3 files changed

+7
-0
lines changed

3 files changed

+7
-0
lines changed

opamp-client/src/main/java/io/opentelemetry/opamp/client/internal/connectivity/websocket/OkHttpWebSocket.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ public void onOpen(@Nonnull okhttp3.WebSocket webSocket, @Nonnull Response respo
8383
@Override
8484
public void onClosing(@Nonnull okhttp3.WebSocket webSocket, int code, @Nonnull String reason) {
8585
status.set(Status.CLOSING);
86+
delegate.onClosing();
8687
}
8788

8889
@Override

opamp-client/src/main/java/io/opentelemetry/opamp/client/internal/request/service/WebSocketRequestService.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -219,6 +219,11 @@ private void retryConnection() {
219219
startConnection();
220220
}
221221

222+
@Override
223+
public void onClosing() {
224+
// Noop
225+
}
226+
222227
@Override
223228
public void onClosed() {
224229
// If this service isn't stopped, we should retry connecting.

opamp-client/src/test/java/io/opentelemetry/opamp/client/internal/connectivity/websocket/OkHttpWebSocketTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ private void callOnClosed() {
136136

137137
private void callOnClosing() {
138138
listenerCaptor.getValue().onClosing(mock(), 0, "");
139+
verify(listener).onClosing();
139140
}
140141

141142
private void callOnFailure() {

0 commit comments

Comments
 (0)