map min duration

Author: zeitlinger

span-stacktrace/README.md

@@ -32,9 +32,8 @@ You can enable the stacktrace span processor using declarative YAML configuratio
 file_format: 1.0-rc.1
 tracer_provider:
   processors:
-    - experimental-stacktrace:
-        min:
-          duration: 10 # minimal duration in ms, default is 5, MUST be an integer
+    - experimental_stacktrace:
+        min_duration: 10 # minimal duration in ms, default is 5, MUST be an integer
         filter: my.class.Name # optional, default is to include all spans
 ```
 

span-stacktrace/src/main/java/io/opentelemetry/contrib/stacktrace/StackTraceAutoConfig.java

@@ -27,7 +27,7 @@ public class StackTraceAutoConfig implements AutoConfigurationCustomizerProvider
   private static final Logger log = Logger.getLogger(StackTraceAutoConfig.class.getName());
 
   static final String PREFIX = "otel.java.experimental.span-stacktrace.";
-  private static final String CONFIG_MIN_DURATION = PREFIX + "min.duration";
+  static final String CONFIG_MIN_DURATION = PREFIX + "min.duration";
   private static final Duration CONFIG_MIN_DURATION_DEFAULT = Duration.ofMillis(5);
   private static final String CONFIG_FILTER = PREFIX + "filter";
 

span-stacktrace/src/main/java/io/opentelemetry/contrib/stacktrace/StackTraceComponentProvider.java

@@ -23,6 +23,7 @@ public String getName() {
   public SpanProcessor create(DeclarativeConfigProperties config) {
     return StackTraceAutoConfig.create(
         new DeclarativeConfigPropertiesBridgeBuilder()
+            .addMapping(StackTraceAutoConfig.CONFIG_MIN_DURATION, "min_duration")
             .addMapping(StackTraceAutoConfig.PREFIX, "")
             .build(config));
   }

span-stacktrace/src/main/java/io/opentelemetry/contrib/stacktrace/StackTraceSpanProcessor.java

@@ -94,4 +94,14 @@ private static String removeInternalFrames(String stackTrace) {
     }
     return stackTrace.substring(nextNewLine + 1);
   }
+
+  @Override
+  public String toString() {
+    return "StackTraceSpanProcessor{"
+        + "minSpanDurationNanos="
+        + minSpanDurationNanos
+        + ", filterPredicate="
+        + filterPredicate
+        + '}';
+  }
 }

span-stacktrace/src/test/java/io/opentelemetry/contrib/stacktrace/StackTraceComponentProviderTest.java

@@ -11,6 +11,8 @@
 import io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfiguration;
 import java.io.ByteArrayInputStream;
 import java.nio.charset.StandardCharsets;
+import java.util.Locale;
+import java.util.concurrent.TimeUnit;
 import org.junit.jupiter.api.Test;
 
 class StackTraceComponentProviderTest {
@@ -20,13 +22,20 @@ void endToEnd() {
         "file_format: 1.0-rc.1\n"
             + "tracer_provider:\n"
             + "  processors:\n"
-            + "    - experimental_stacktrace:\n";
+            + "    - experimental_stacktrace: \n"
+            + "        min_duration: 100\n"
+            + "        filter: io.opentelemetry.contrib.stacktrace.StackTraceSpanProcessorTest$YesPredicate\n";
 
     OpenTelemetrySdk openTelemetrySdk =
         DeclarativeConfiguration.parseAndCreate(
             new ByteArrayInputStream(yaml.getBytes(StandardCharsets.UTF_8)));
 
     assertThat(openTelemetrySdk.getSdkTracerProvider().toString())
-        .contains("StackTraceSpanProcessor");
+        .contains(
+            String.format(
+                Locale.ROOT,
+                "StackTraceSpanProcessor{minSpanDurationNanos=%d, "
+                    + "filterPredicate=io.opentelemetry.contrib.stacktrace.StackTraceSpanProcessorTest$YesPredicate",
+                TimeUnit.MILLISECONDS.toNanos(100)));
   }
 }