Skip to content

Commit eab7c69

Browse files
committed
register -> add
1 parent cf72d19 commit eab7c69

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

jmx-scraper/src/integrationTest/java/io/opentelemetry/contrib/jmxscraper/target_systems/ActiveMqIntegrationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ protected JmxScraperContainer customizeScraperContainer(
3939
@Override
4040
protected MetricsVerifier createMetricsVerifier() {
4141
return MetricsVerifier.create()
42-
.register(
42+
.add(
4343
"activemq.consumer.count",
4444
metric ->
4545
metric

jmx-scraper/src/integrationTest/java/io/opentelemetry/contrib/jmxscraper/target_systems/JvmIntegrationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ protected MetricsVerifier createMetricsVerifier() {
5252
"total number of collections that have occurred",
5353
"1",
5454
gcCollectionLabels)
55-
.register(
55+
.add(
5656
"jvm.gc.collections.elapsed",
5757
metric ->
5858
metric

jmx-scraper/src/integrationTest/java/io/opentelemetry/contrib/jmxscraper/target_systems/MetricsVerifier.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public MetricsVerifier disableStrictMode() {
4545
}
4646

4747
@CanIgnoreReturnValue
48-
public MetricsVerifier register(String metricName, Consumer<MetricAssert> assertion) {
48+
public MetricsVerifier add(String metricName, Consumer<MetricAssert> assertion) {
4949
assertions.put(
5050
metricName,
5151
metric -> {
@@ -60,7 +60,7 @@ public MetricsVerifier register(String metricName, Consumer<MetricAssert> assert
6060
// TODO: can now be inlined
6161
@CanIgnoreReturnValue
6262
public MetricsVerifier assertGauge(String metricName, String description, String unit) {
63-
return register(
63+
return add(
6464
metricName,
6565
metric ->
6666
metric
@@ -73,7 +73,7 @@ public MetricsVerifier assertGauge(String metricName, String description, String
7373
// TODO: can now be inlined
7474
@CanIgnoreReturnValue
7575
public MetricsVerifier assertCounter(String metricName, String description, String unit) {
76-
return register(
76+
return add(
7777
metricName,
7878
metric ->
7979
metric
@@ -86,7 +86,7 @@ public MetricsVerifier assertCounter(String metricName, String description, Stri
8686
// TODO: can now be inlined
8787
@CanIgnoreReturnValue
8888
public MetricsVerifier assertUpDownCounter(String metricName, String description, String unit) {
89-
return register(
89+
return add(
9090
metricName,
9191
metric ->
9292
metric
@@ -101,7 +101,7 @@ public MetricsVerifier assertUpDownCounter(String metricName, String description
101101
@CanIgnoreReturnValue
102102
public final MetricsVerifier assertGaugeWithAttributes( // only used in activemq
103103
String metricName, String description, String unit, Map.Entry<String, String>... attributes) {
104-
return register(
104+
return add(
105105
metricName,
106106
metric ->
107107
metric
@@ -116,7 +116,7 @@ public final MetricsVerifier assertGaugeWithAttributes( // only used in activemq
116116
@CanIgnoreReturnValue
117117
public final MetricsVerifier assertCounterWithAttributes(
118118
String metricName, String description, String unit, Map<String, String>... attributeSets) {
119-
return register(
119+
return add(
120120
metricName,
121121
metric ->
122122
metric
@@ -131,7 +131,7 @@ public final MetricsVerifier assertCounterWithAttributes(
131131
@CanIgnoreReturnValue
132132
public final MetricsVerifier assertCounterWithAttributes(
133133
String metricName, String description, String unit, Map.Entry<String, String>... attributes) {
134-
return register(
134+
return add(
135135
metricName,
136136
metric ->
137137
metric
@@ -146,7 +146,7 @@ public final MetricsVerifier assertCounterWithAttributes(
146146
@CanIgnoreReturnValue
147147
public final MetricsVerifier assertUpDownCounterWithAttributes(
148148
String metricName, String description, String unit, Map.Entry<String, String>... attributes) {
149-
return register(
149+
return add(
150150
metricName,
151151
metric ->
152152
metric
@@ -160,7 +160,7 @@ public final MetricsVerifier assertUpDownCounterWithAttributes(
160160
@CanIgnoreReturnValue
161161
public MetricsVerifier assertTypedCounter(
162162
String metricName, String description, String unit, List<String> types) {
163-
return register(
163+
return add(
164164
metricName,
165165
metric ->
166166
metric.hasDescription(description).hasUnit(unit).isCounter().hasTypedDataPoints(types));
@@ -170,7 +170,7 @@ public MetricsVerifier assertTypedCounter(
170170
@CanIgnoreReturnValue
171171
public MetricsVerifier assertTypedGauge(
172172
String metricName, String description, String unit, List<String> types) {
173-
return register(
173+
return add(
174174
metricName,
175175
metric ->
176176
metric.hasDescription(description).hasUnit(unit).isGauge().hasTypedDataPoints(types));

0 commit comments

Comments
 (0)