Skip to content

Commit f4999ac

Browse files
committed
Addressing PR comments
1 parent c39e2a1 commit f4999ac

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

disk-buffering/src/main/java/io/opentelemetry/contrib/disk/buffering/internal/storage/FileSignalStorage.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@ public CompletableFuture<WriteResult> write(Collection<T> items) {
4949
return CompletableFuture.completedFuture(WriteResult.successful());
5050
}
5151
logger.fine("Could not store batch in disk.");
52-
return CompletableFuture.completedFuture(WriteResult.error(null));
52+
return CompletableFuture.completedFuture(
53+
WriteResult.error(new Exception("Could not store batch in disk for an unknown reason.")));
5354
} catch (IOException e) {
5455
logger.log(
5556
Level.WARNING,

disk-buffering/src/main/java/io/opentelemetry/contrib/disk/buffering/internal/storage/FolderManager.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,8 @@ public static FolderManager create(
3131
File destinationDir, FileStorageConfiguration configuration, Clock clock) {
3232
if (destinationDir.isFile()) {
3333
throw new IllegalArgumentException("destinationDir must be a directory");
34-
} else if (!destinationDir.exists()) {
34+
}
35+
if (!destinationDir.exists()) {
3536
if (!destinationDir.mkdirs()) {
3637
throw new IllegalStateException("Could not create dir: " + destinationDir);
3738
}

0 commit comments

Comments
 (0)