add a few comments for clarity

SylvainJuge · SylvainJuge · commit f9841f29f33c · 2025-01-31T22:39:48.000+01:00
diff --git a/jmx-scraper/src/integrationTest/java/io/opentelemetry/contrib/jmxscraper/JmxConnectionTest.java b/jmx-scraper/src/integrationTest/java/io/opentelemetry/contrib/jmxscraper/JmxConnectionTest.java
@@ -118,7 +118,9 @@ private static JmxScraperContainer scraperContainer() {
     return new JmxScraperContainer(DUMMY_OTLP_ENDPOINT, SCRAPER_BASE_IMAGE)
         .withLogConsumer(new Slf4jLogConsumer(jmxScraperLogger))
         .withNetwork(network)
+        // mandatory to have a target system even if we don't collect metrics
         .withTargetSystem("jvm")
+        // we are only testing JMX connection here
         .withTestJmx();
   }
 

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,9 @@ private static JmxScraperContainer scraperContainer() {`
`118`	`118`	`return new JmxScraperContainer(DUMMY_OTLP_ENDPOINT, SCRAPER_BASE_IMAGE)`
`119`	`119`	`.withLogConsumer(new Slf4jLogConsumer(jmxScraperLogger))`
`120`	`120`	`.withNetwork(network)`
	`121`	`+ // mandatory to have a target system even if we don't collect metrics`
`121`	`122`	`.withTargetSystem("jvm")`
	`123`	`+ // we are only testing JMX connection here`
`122`	`124`	`.withTestJmx();`
`123`	`125`	`}`
`124`	`126`