pr review

Author: zeitlinger

inferred-spans/src/main/java/io/opentelemetry/contrib/inferredspans/InferredSpansAutoConfig.java

@@ -22,7 +22,7 @@ public void customize(AutoConfigurationCustomizer config) {
     config.addTracerProviderCustomizer(
         (providerBuilder, properties) -> {
           if (properties.getBoolean(ENABLED_OPTION, false)) {
-            providerBuilder.addSpanProcessor(InferredSpansConfig.create(properties));
+            providerBuilder.addSpanProcessor(InferredSpansConfig.createSpanProcessor(properties));
           } else {
             log.finest(
                 "Not enabling inferred spans processor because " + ENABLED_OPTION + " is not set");

inferred-spans/src/main/java/io/opentelemetry/contrib/inferredspans/InferredSpansConfig.java

@@ -5,6 +5,7 @@
 
 package io.opentelemetry.contrib.inferredspans;
 
+import static java.util.Collections.unmodifiableList;
 import static java.util.stream.Collectors.toList;
 
 import io.opentelemetry.api.trace.SpanBuilder;
@@ -37,7 +38,24 @@ private InferredSpansConfig() {}
   static final String PARENT_OVERRIDE_HANDLER_OPTION =
       "otel.inferred.spans.parent.override.handler";
 
-  static SpanProcessor create(ConfigProperties properties) {
+  static final List<String> ALL_PROPERTIES =
+      unmodifiableList(
+          Arrays.asList(
+              ENABLED_OPTION,
+              LOGGING_OPTION,
+              DIAGNOSTIC_FILES_OPTION,
+              SAFEMODE_OPTION,
+              POSTPROCESSING_OPTION,
+              SAMPLING_INTERVAL_OPTION,
+              MIN_DURATION_OPTION,
+              INCLUDED_CLASSES_OPTION,
+              EXCLUDED_CLASSES_OPTION,
+              INTERVAL_OPTION,
+              DURATION_OPTION,
+              LIB_DIRECTORY_OPTION,
+              PARENT_OVERRIDE_HANDLER_OPTION));
+
+  static SpanProcessor createSpanProcessor(ConfigProperties properties) {
     InferredSpansProcessorBuilder builder = InferredSpansProcessor.builder();
 
     PropertiesApplier applier = new PropertiesApplier(properties);

inferred-spans/src/main/java/io/opentelemetry/contrib/inferredspans/InferredSpansComponentProvider.java renamed to inferred-spans/src/main/java/io/opentelemetry/contrib/inferredspans/InferredSpansSpanProcessorProvider.java

@@ -13,7 +13,9 @@
 
 @SuppressWarnings("rawtypes")
 @AutoService(ComponentProvider.class)
-public class InferredSpansComponentProvider implements ComponentProvider<SpanProcessor> {
+public class InferredSpansSpanProcessorProvider implements ComponentProvider<SpanProcessor> {
+
+  private static final String PREFIX = "otel.inferred.spans.";
 
   @Override
   public String getName() {
@@ -22,12 +24,16 @@ public String getName() {
 
   @Override
   public SpanProcessor create(DeclarativeConfigProperties config) {
-    return InferredSpansConfig.create(
-        new DeclarativeConfigPropertiesBridgeBuilder()
-            // crop the prefix, because the properties are under the "experimental_inferred_spans"
-            // processor
-            .addMapping("otel.inferred.spans.", "")
-            .build(config));
+    DeclarativeConfigPropertiesBridgeBuilder builder =
+        new DeclarativeConfigPropertiesBridgeBuilder();
+
+    for (String property : InferredSpansConfig.ALL_PROPERTIES) {
+      // 1. crop the prefix, because the properties are under the "experimental_inferred_spans"
+      // 2. we want all properties flat under "otel.inferred.spans.*"
+      builder.addMapping(property, property.substring(PREFIX.length()).replace('.', '_'));
+    }
+
+    return InferredSpansConfig.createSpanProcessor(builder.build(config));
   }
 
   @Override

inferred-spans/src/test/java/io/opentelemetry/contrib/inferredspans/InferredSpansCustomizerProviderTest.java

@@ -37,9 +37,7 @@ void declarativeConfig() {
             + "  processors:\n"
             + "    - experimental_inferred_spans:\n"
             + "        enabled: false\n"
-            + "        backup:\n"
-            + "          diagnostic:\n"
-            + "            files: true\n";
+            + "        backup_diagnostic_files: true\n";
 
     OpenTelemetrySdk sdk =
         DeclarativeConfiguration.parseAndCreate(