Skip to content

[disk-buffering] StorageConfiguration.Builder.setTemporaryFileProvider() exposes internal class #1772

@bencehornak

Description

@bencehornak

The public StorageConfiguration.Builder.setTemporaryFileProvider class requires an instance of the TemporaryFileProvider class, which is situated in the io.opentelemetry.contrib.disk.buffering.**internal**.files package:

public abstract Builder setTemporaryFileProvider(TemporaryFileProvider value);

As a result, the users of the library need to import the internal class if they wish to provide a custom implementation.

My suggestion is to move the TemporaryFileProvider class to the io.opentelemetry.contrib.disk.buffering package to explicitly mark it as public API.

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions