jmx scraper: add missing relevant config options #1979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
reviewed
Jun 30, 2025
breedx-splk
approved these changes
Jun 30, 2025
Contributor
breedx-splk
left a comment
breedx-splk
left a comment
There was a problem hiding this comment.
One small comment, the phrasing was a little clunky as well, but fine. This might need a rebase after we figure out the markdown link check stuff.
Co-authored-by: jason plumb <[email protected]>
Member
|
@SylvainJuge ignore the link check failure, but can you check out the "lint" check failure? |
breedx-splk
reviewed
Jun 30, 2025
Contributor
I thinks that's on me....my suggestion had some junk in it. Fixing. |
breedx-splk
reviewed
Jun 30, 2025
Merged
via the queue into
open-telemetry:main
with commit Jun 30, 2025
88f07b6
29 of 30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
jmx-scraper relies on the SDK and thus supports most of the SDK configuration options.
The
otel.service.nameandotel.resource.attributesare commonly used and were missing from documentation, this PR adds them.