Skip to content

Consistent sampling tests are flaky #2050

@laurit

Description

@laurit

Component(s)

consistent-sampling

What happened?

https://scans.gradle.com/s/lkud6oenfjrhi
https://scans.gradle.com/s/2xvjyd25fvjng
Seems to be fairly easy to reproduce, change @Test to @RepeatedTest(100).
added

    System.err.println(originalNumberOfSpans + " " + observedPvalues + " " + samplingProbability);
    System.err.println(expectedProbabilities + " " + Arrays.toString(observedValues));

to


for failing test it printed out

1000000 {4=37074, 5=12751} 0.05
{4=0.037500000000000006, 5=0.012499999999999997, NOT SAMPLED=0.95} [37074, 12751, 950175]

Component version

1.48.0

Log output

No response

Additional context

No response

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions