Skip to content

Conversation

@JacekPietrasSpotOn
Copy link
Contributor

Description:

Bug fix - Catching possible deserialization problem in ByteArrayProtoReader32 and mapping it to already existing DeserializationException

Fatal Exception: java.lang.IllegalStateException: Unexpected call to beginMessage()
       at com.squareup.wire.ByteArrayProtoReader32.beginMessage(ByteArrayProtoReader32.kt:92)
       at com.squareup.wire.ProtoReader32AsProtoReader.beginMessage(ProtoReader32AsProtoReader.kt:31)
       at io.opentelemetry.diskbuffering.proto.logs.v1.ResourceLogs$ProtoAdapter_ResourceLogs.decode(ResourceLogs.java:215)
       at io.opentelemetry.diskbuffering.proto.logs.v1.ResourceLogs$ProtoAdapter_ResourceLogs.decode(ResourceLogs.java:177)
       at io.opentelemetry.diskbuffering.proto.logs.v1.LogsData$ProtoAdapter_LogsData.decode(LogsData.java:155)
       at io.opentelemetry.diskbuffering.proto.logs.v1.LogsData$ProtoAdapter_LogsData.decode(LogsData.java:124)

Existing Issue(s):

open-telemetry/opentelemetry-android#840
open-telemetry/opentelemetry-android#1050

Testing:

Unit tests

Documentation:

No functional changes

Outstanding items:

No functional changes

@JacekPietrasSpotOn JacekPietrasSpotOn requested a review from a team as a code owner August 22, 2025 13:30
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 22, 2025

CLA Signed

  • ✅login: JacekPietrasSpotOn / name: jacekpietras / (8a00ac8)
  • ✅login: otelbot[bot] / name: otelbot / (8baa097)

The committers listed above are authorized under a signed CLA.

@otelbot-java-contrib
Copy link
Contributor

🔧 The result from spotlessApply was committed to the PR branch.

@breedx-splk breedx-splk modified the milestone: v1.49.0 Aug 22, 2025
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@breedx-splk breedx-splk added this pull request to the merge queue Aug 22, 2025
Merged via the queue into open-telemetry:main with commit 2ee0768 Aug 22, 2025
29 checks passed
@Ejdangerfield
Copy link

LGTM thank you!

Do we know when this is coming to otel-android?

@trask
Copy link
Member

trask commented Sep 11, 2025

the next release of this repo will hopefully be next Tue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants